Prevent recursion attacks in EXT4Formatter.unlink#415
Open
wlan0 wants to merge 2 commits intoapple:mainfrom
Open
Prevent recursion attacks in EXT4Formatter.unlink#415wlan0 wants to merge 2 commits intoapple:mainfrom
wlan0 wants to merge 2 commits intoapple:mainfrom
Conversation
wlan0
force-pushed
the
main
branch
3 times, most recently
from
3d2676c to
7bafb59
Compare
jglogan
requested changes
Apr 6, 2026
| for childPtr in pathNode.children { | ||
| try self.unlink(path: path.join(childPtr.pointee.name)) | ||
| // Iterative breath-first traversal of the FileTree to prevent recursion attacks | ||
| var queue: [(parent: Ptr<FileTree.FileTreeNode>?, entry: Ptr<FileTree.FileTreeNode>)] = pathNode.children.map { (pathPtr, $0) } |
Contributor
There was a problem hiding this comment.
parent need not be optional; there's no way it can be nil right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue doesn't affect any of our existing products. This is a preemptive fix for downstream consumers of EXT4.format where, in some platforms, leading
//in the path could get resolved into a FileTree that looks like this