Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1014 +/- ##
==========================================
- Coverage 95.80% 92.61% -3.19%
==========================================
Files 61 71 +10
Lines 8143 10051 +1908
Branches 0 10051 +10051
==========================================
+ Hits 7801 9309 +1508
- Misses 342 450 +108
- Partials 0 292 +292 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a9596b5 to
9786ef1
Compare
2095a6a to
7b488af
Compare
7b488af to
51a1a26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a new
aws-lc-rs-benchcrate — a standalone benchmarking tool that measures CPU instruction counts using Valgrind's callgrind. Unlike wall-clock benchmarks, instruction counts are deterministic and noise-free, which makes them well-suited for catching unexpected performance changes in CI.The tool covers AEAD, digest, HMAC, HKDF, key agreement, and signature operations (55 benchmarks total). A GitHub Actions workflow runs these on every PR and pushes a comparison report as a PR comment.
Also cleans up
aws-lc-rs-testing:ringandopenssltruly optional (previously they were unconditional dev-deps behind empty feature flags)#![cfg(feature = "...")]UnparsedPublicKeyinstead of the deprecatedVerificationAlgorithmtraitagree_ephemeralcalls in agreement benchmarks to accommodate the differingaws-lc-rs/ringsignaturesCall-outs:
aws-lc-rs-benchis Linux-only for instruction counting (requires Valgrind). Awalltimesubcommand is available for quick local testing on any platform.crabgrindcrate is pulled in only on Linux viacfg(target_os = "linux").aws-lc-rs-testingdependency changes meancargo test -p aws-lc-rs-testing(without features) now compiles the ring/openssl comparison tests to zero test cases. Pass--features ring-benchmarks,openssl-benchmarksto run them.Testing:
cargo check -p aws-lc-rs-benchandcargo test -p aws-lc-rs-testing --features ring-benchmarks,openssl-benchmarksboth pass.walltimemode runs all 55 benchmarks end-to-end.aws-lc-rs-testingtest targets correctly compile to 0 tests (feature gates work).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.