fix: use :: in pip+git requirement#61
Merged
jolars merged 1 commit intobenchopt:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates solver dependency specifications to use the pip:: prefix for VCS (git+https://...) pip requirements, aligning with the intended benchopt/pip requirement format.
Changes:
- Switch
pip:git+https://...topip::git+https://...in two solvers’requirements. - Keep (but now potentially outdated) TODO comments about a future switch to
pip::git....
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| solvers/slope_path.py | Updates the solver’s git-based pip requirement to pip::git+.... |
| solvers/pgd_safe_screening.py | Updates the solver’s git-based pip requirement to pip::git+.... |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update solvers/slope_path.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Update solvers/pgd_safe_screening.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jolars
force-pushed
the
use-double-colon
branch
from
83ef031 to
b66c851
Compare
tomMoral
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for requirements to use
::in pip+git style requirements.