Skip to content

WH-042: code changes aren't showing up in the artifacts bar until after a refresh, whereas specs and mockups do show up automatically - fix#72

Open
edmofro wants to merge 8 commits intomainfrom
workhorse/wh-042-spec
Open

WH-042: code changes aren't showing up in the artifacts bar until after a refresh, whereas specs and mockups do show up automatically - fix#72
edmofro wants to merge 8 commits intomainfrom
workhorse/wh-042-spec

Conversation

@edmofro
Copy link
Copy Markdown
Member

@edmofro edmofro commented Apr 3, 2026

Summary

The artifacts bar updates in real time when code changes are saved, consistent with the existing behaviour for specs and mockups, without requiring a page refresh.

Journey

  • Implementation in progress — fixing artifact refresh logic in CardDetailLayout, CardWorkspace, and related components
  • Artifact refresh logic refactored — consolidated imports, removed dead code, implemented real-time committedFiles tracking in CardWorkspace

Specs

  • .workhorse/specs/agent-sdk-session.md

Changed files

  • prisma/schema.prisma
  • src/lib/git/commitSpecs.ts
  • src/lib/handoff/generatePrompt.ts
  • src/app/api/auto-commit/route.ts
  • src/app/api/card-detail/route.ts
  • src/app/api/create-pr/route.ts
  • src/app/api/handoff/route.ts
  • src/app/api/jockey/route.ts
  • src/app/api/agent-session/route.ts
  • src/components/card/CardDetailShell.tsx
  • src/lib/hooks/queries.ts
  • src/components/card/CardDetailLayout.tsx
  • src/components/card/CardWorkspace.tsx

Test plan

Review Hero

  • Run Review Hero
  • Auto-fix review suggestions
  • Auto-fix CI failures

@review-hero
Copy link
Copy Markdown

review-hero bot commented Apr 3, 2026

🦸 Review Hero Summary
12 agents reviewed this PR | 0 critical | 0 suggestions | 0 nitpicks | Filtering: consensus 3 voters, 3 below threshold

No issues found. Looks good!

Below consensus threshold (3 unique issues not confirmed by majority)
Location Agent Severity Comment
src/app/api/agent-session/route.ts:724 Bugs & Correctness suggestion getChangedFiles is included directly in the Promise.all without a fallback. If it rejects (e.g. the worktree was cleaned up or git fails in an unexpected way not caught by its internal try/catch), ...
src/components/card/CardWorkspace.tsx:377 Project Conventions nitpick Australian/NZ English spelling: 'artifacts' should be 'artefacts'. The comment reads '// Refresh code files after a commit so the artifacts bar updates with' — fix to 'artefacts bar'.
src/components/card/CardWorkspace.tsx:383 Bugs & Correctness suggestion The fetch inside the committedFiles useEffect has no cleanup/AbortController. If the component unmounts (user navigates away) while the request is in-flight, the .then callbacks still execute and c...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants