Update ping-protocol submodule & regenerate definitions.py with correct OMNISCAN450_SET_SPEED_OF_SOUND id#170
Open
Maexerich wants to merge 1 commit intobluerobotics:masterfrom
Open
Update ping-protocol submodule & regenerate definitions.py with correct OMNISCAN450_SET_SPEED_OF_SOUND id#170Maexerich wants to merge 1 commit intobluerobotics:masterfrom
Maexerich wants to merge 1 commit intobluerobotics:masterfrom
Conversation
…cted OMNISCAN450_SET_SPEED_OF_SOUND id
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR on a open-source codebase. I used AI to navigate the process but have manually reviewed everything to the best of my knowledge.
Summary
This PR:
lib/ping-protocolsubmodule reference to use the fixed protocol definitionsbrping/definitions.pywith the corrected message ID (although not tracked by git).Related Fix
Depends on: bluerobotics/ping-protocol# at commit hash: 629510
Changes
.gitmodules: Updated submodule URL to point to fixed ping-protocol fork temporarilylib/ping-protocol: Now references commit with corrected OMNISCAN450_SET_SPEED_OF_SOUND ID(-
brping/definitions.py: Regenerated; now containsOMNISCAN450_SET_SPEED_OF_SOUND = 116) (not tracked by git)How This Was Generated