Skip to content

CI: platforms update#1153

Open
grisumbras wants to merge 3 commits intoboostorg:developfrom
grisumbras:ci/platforms-update
Open

CI: platforms update#1153
grisumbras wants to merge 3 commits intoboostorg:developfrom
grisumbras:ci/platforms-update

Conversation

@grisumbras
Copy link
Copy Markdown
Member

No description provided.

@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented Mar 31, 2026

An automated preview of the documentation is available at https://1153.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-04-03 15:12:48 UTC

@cppalliance-bot
Copy link
Copy Markdown

cppalliance-bot commented Mar 31, 2026

GCOVR code coverage report https://1153.json.prtest2.cppalliance.org/gcovr/index.html
LCOV code coverage report https://1153.json.prtest2.cppalliance.org/genhtml/index.html
Coverage Diff Report https://1153.json.prtest2.cppalliance.org/diff-report/index.html

Build time: 2026-04-03 15:30:17 UTC

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.68%. Comparing base (70efd4b) to head (bd05498).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1153   +/-   ##
========================================
  Coverage    93.68%   93.68%           
========================================
  Files           91       91           
  Lines         9164     9164           
========================================
  Hits          8585     8585           
  Misses         579      579           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70efd4b...bd05498. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the ci/platforms-update branch 3 times, most recently from 15944e3 to c0381d0 Compare April 1, 2026 16:44
@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the ci/platforms-update branch from c0381d0 to f5a065d Compare April 2, 2026 08:26
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the ci/platforms-update branch from f5a065d to 42a7db6 Compare April 2, 2026 09:48
@cppalliance-bot
Copy link
Copy Markdown

@sdarwin
Copy link
Copy Markdown
Collaborator

sdarwin commented Apr 2, 2026

relocating this comment from slack to the PR:

I think this update is not following the intended idea. Compare to boostorg/url. The strategy is to install a very small matrix in .drone.star which calls generate(). However you don't need to define the entirety of generate() in drone.star. If that should be updated, then submit a PR to cppalliance/ci-automation. The generate() function lives in ci-automation and is shared among other repos. You can still include custom jobs, beyond those.

However, just speculating, maybe that is what you are doing here already.

  • Debug the generate() function, if there is a problem
  • send a PR to ci-automation. and then switch back to using that version.

@sdarwin
Copy link
Copy Markdown
Collaborator

sdarwin commented Apr 2, 2026

Ok, I hadn't examined it carefully. Perhaps you are completely re-writing generate() . It's a totally different function. Not a small bug fix. So the above comments are not valid.

@grisumbras
Copy link
Copy Markdown
Member Author

My goal is to write a generate function that I satsifies my needs then see if I can get that merged with the one in cppalliance/ci-automation. It has certain differences that I think makes it better than the original.

@sdarwin
Copy link
Copy Markdown
Collaborator

sdarwin commented Apr 2, 2026

Yet another implementation option: Flamefire's job_impl() function https://github.com/boostorg/boost-ci/blob/master/ci/drone/functions.star

And pdimov's linux_pipeline() https://github.com/boostorg/unordered/blob/develop/.drone.jsonnet

@grisumbras grisumbras force-pushed the ci/platforms-update branch from 42a7db6 to 3b7f244 Compare April 2, 2026 16:42
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the ci/platforms-update branch from 3b7f244 to 0b6085c Compare April 2, 2026 18:24
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the ci/platforms-update branch from 0b6085c to 6851361 Compare April 3, 2026 11:28
@cppalliance-bot
Copy link
Copy Markdown

@sdarwin
Copy link
Copy Markdown
Collaborator

sdarwin commented Apr 3, 2026

macos jobs aren't running.

Analysis:

Consider these functions: "linux_cxx","windows_cxx","osx_cxx","freebsd_cxx"
I am not sure how your code interacts with those. If there is a strict wall between the new logic and these earlier functions, and it calls "osx_cxx" as before, you would expect it to work correctly.

However it isn't.

If some variables are getting passed through, it could be an explanation for a problem.

Inside of osx_cxx:

    "platform": {
      "os": "darwin",
      "arch": arm64
    },

whereas you are defining:

            'platforms': {
                ('macos', 'x86_64'): {
                    'xcode_version': '15.4.0',
                },

The platform should be 'darwin' and not 'macos'.
The architecture should be 'arm64' and not 'x86_64'.

To repeat, if the "osx_cxx" is called as before, without interference I'd expect it to be fine, but if somehow the values 'macos' or 'x86_64' are bleeding through, that could break it. Try switching the code to use 'darwin' 'arm64'.

If you put back the previous matrix job osx_cxx("..") as-is, that would work, so the problem is somehow involved with the new logic.

@grisumbras grisumbras force-pushed the ci/platforms-update branch from 6851361 to 46b602b Compare April 3, 2026 15:05
@cppalliance-bot
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants