Conversation
|
@marcalexiei is attempting to deploy a commit to the Changesets Team on Vercel. A member of the Team first needs to authorize it. |
|
@marcalexiei could you rebase this now? Let's see if the CI checks actually work now :p |
marcalexiei
left a comment
marcalexiei
left a comment
There was a problem hiding this comment.
could you rebase this now?
Done, this PR is now in sync with master
Let's see if the CI checks actually work now :p
Everything works as expected!
I saw few warnings in the PR CI run and I've created separate threads to discuss them.
There was a problem hiding this comment.
> warning " > vitest@4.1.2" has incorrect peer dependency "vite@^6.0.0 || ^7.0.0 || ^8.0.0".
Likely caused by
Lines 39 to 41 in be84759
Can we install vite latest version (8.0.3) to remove it or there is a particular reason to use this beta?
There was a problem hiding this comment.
yes, with vitest 4.1 we can remove the override
.github/workflows/ci.yml
Outdated
| - name: Setup dependencies | ||
| uses: ./.github/actions/ci-setup | ||
|
|
||
| - name: Run format:check |
There was a problem hiding this comment.
let's match the style in the main Changesets repo where "Lint" is a separate job and it's required by CI OK
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 participants
oxfmtas formatterformat:checkscript run onci.yml