Skip to content

[WIP] fix logs using fallback#800

Closed
ilopezluna wants to merge 2 commits intomainfrom
fix-logs-command
Closed

[WIP] fix logs using fallback#800
ilopezluna wants to merge 2 commits intomainfrom
fix-logs-command

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logs command to enhance testability and support diverse environments, including Moby, Cloud, and Desktop. It introduces interfaces for Docker client interactions and container discovery, enabling more robust unit testing. The implementation now dynamically selects between container logs and local file logs based on the engine configuration and target URL. Extensive unit tests have been added to ensure correct behavior across different platforms and scenarios. I have no feedback to provide as no issues were identified.

@ilopezluna ilopezluna closed this Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant