Skip to content

[7.0] Add type forwards to public Abstractions types#4117

Open
paulmedynski wants to merge 1 commit intorelease/7.0from
cherry-pick/7.0/4067
Open

[7.0] Add type forwards to public Abstractions types#4117
paulmedynski wants to merge 1 commit intorelease/7.0from
cherry-pick/7.0/4067

Conversation

@paulmedynski
Copy link
Copy Markdown
Contributor

Cherry-pick of #4067 to release/7.0

Copilot AI review requested due to automatic review settings March 31, 2026 19:29
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 31, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cherry-picks #4067 into release/7.0 to preserve binary compatibility by type-forwarding several public authentication-related types from Microsoft.Data.SqlClient to the Microsoft.Data.SqlClient.Extensions.Abstractions assembly.

Changes:

  • Add assembly-level TypeForwardedTo attributes for the moved Abstractions types.
  • Wire the new type-forward source file into legacy netfx/netcore build and ref projects.
  • Add a unit test validating the forwarded types still load via the Microsoft.Data.SqlClient assembly and originate from the Abstractions assembly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient/tests/UnitTests/TypeForwardTests.cs Adds coverage to ensure the forwarded Abstractions types remain loadable via Microsoft.Data.SqlClient and resolve to the Abstractions assembly.
src/Microsoft.Data.SqlClient/src/TypeForwards.Abstractions.cs Introduces the actual type-forward declarations for the moved public types.
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Includes the new type-forward source in the legacy netfx build project.
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj Includes the new type-forward source in the legacy netfx reference-assembly project.
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Includes the new type-forward source in the legacy netcore build project.
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj Includes the new type-forward source in the legacy netcore reference-assembly project.

@paulmedynski paulmedynski added this to the 7.0.1 milestone Mar 31, 2026
@mdaigle mdaigle moved this from To triage to In review in SqlClient Board Apr 1, 2026
@paulmedynski paulmedynski marked this pull request as ready for review April 2, 2026 15:48
@paulmedynski paulmedynski requested a review from a team as a code owner April 2, 2026 15:48
@paulmedynski paulmedynski modified the milestones: 7.0.1, 7.0.2 Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.66%. Comparing base (864f666) to head (93e3f2f).
⚠️ Report is 2 commits behind head on release/7.0.

❗ There is a different number of reports uploaded between BASE (864f666) and HEAD (93e3f2f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (864f666) HEAD (93e3f2f)
CI-SqlClient 1 0
Additional details and impacted files
@@               Coverage Diff               @@
##           release/7.0    #4117      +/-   ##
===============================================
- Coverage        73.07%   65.66%   -7.42%     
===============================================
  Files              280      275       -5     
  Lines            42997    65825   +22828     
===============================================
+ Hits             31422    43226   +11804     
- Misses           11575    22599   +11024     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 65.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Missing Type Microsoft.Data.SqlClient.SqlAuthenticationMethod - .NET Framework 4.8

4 participants