Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated two existing GitHub Actions workflows to use Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/deploy.yaml (1)
22-27:⚠️ Potential issue | 🔴 CriticalPre-existing bug: Deploy workflow uses wrong image.
This isn't introduced by this PR, but it's critical: Line 24 sets
IMAGEtocontrol_dev:latestwhile Line 19 buildscontrol_deploy:latest. The production deployment is running the dev image instead of the freshly built deploy image.🐛 Proposed fix
- name: Deploy container locally run: | - IMAGE=${{ secrets.DOCKER_HUB_USERNAME }}/control_dev:latest + IMAGE=${{ secrets.DOCKER_HUB_USERNAME }}/control_deploy:latest docker stop CONTROL_DEPLOY || true🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/deploy.yaml around lines 22 - 27, The deploy workflow sets IMAGE to the wrong tag (uses control_dev:latest instead of the built control_deploy:latest); update the IMAGE assignment in the deploy step so it references the same image name/tag that the build step produces (change IMAGE=${{ secrets.DOCKER_HUB_USERNAME }}/control_dev:latest to the built image name control_deploy:latest), ensuring the docker run uses the freshly built control_deploy:latest image.
🧹 Nitpick comments (1)
.github/workflows/pr-build-check.yaml (1)
18-21: Consider pinning Go version to matchgo.modexactly.The workflow uses
1.23.xwhilego.modspecifiesgo 1.23.0withtoolchain go1.23.4. This works sincesetup-gowill install a compatible version, but for reproducibility, consider aligning with the toolchain version.♻️ Optional: Pin to toolchain version
- name: Set up Go uses: actions/setup-go@v5 with: - go-version: '1.23.x' + go-version: '1.23.4'🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/pr-build-check.yaml around lines 18 - 21, The GitHub Actions step using actions/setup-go@v5 currently pins go-version: '1.23.x' which is broader than the project's declared toolchain; update the workflow step to pin the exact toolchain version (e.g., set go-version: '1.23.4') so it matches the go.mod/toolchain and ensures reproducible builds; modify the step that references actions/setup-go@v5 and its go-version input accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-build-check.yaml:
- Around line 29-39: The workflow currently posts a review via
github.rest.pulls.createReview with event: 'REQUEST_CHANGES', which accumulates
and can block merging; change the failing-step's createReview call to use event:
'COMMENT' instead (so builds only leave a comment) or alternatively add a new
success-step that lists reviews via github.rest.pulls.listReviews and dismisses
any reviews where review.user.login === 'github-actions[bot]' and review.state
=== 'CHANGES_REQUESTED' using github.rest.pulls.dismissReview with an
explanatory message; update the step name(s) accordingly and ensure the
success-step has if: success() so stale CHANGES_REQUESTED reviews are cleared
when the build passes.
---
Outside diff comments:
In @.github/workflows/deploy.yaml:
- Around line 22-27: The deploy workflow sets IMAGE to the wrong tag (uses
control_dev:latest instead of the built control_deploy:latest); update the IMAGE
assignment in the deploy step so it references the same image name/tag that the
build step produces (change IMAGE=${{ secrets.DOCKER_HUB_USERNAME
}}/control_dev:latest to the built image name control_deploy:latest), ensuring
the docker run uses the freshly built control_deploy:latest image.
---
Nitpick comments:
In @.github/workflows/pr-build-check.yaml:
- Around line 18-21: The GitHub Actions step using actions/setup-go@v5 currently
pins go-version: '1.23.x' which is broader than the project's declared
toolchain; update the workflow step to pin the exact toolchain version (e.g.,
set go-version: '1.23.4') so it matches the go.mod/toolchain and ensures
reproducible builds; modify the step that references actions/setup-go@v5 and its
go-version input accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 30ba8ede-3d94-424c-8de2-060325d5fc20
📒 Files selected for processing (3)
.github/workflows/deploy.yaml.github/workflows/dev.yaml.github/workflows/pr-build-check.yaml
|
헉.. 기존에 v2로 되어있었군요 pr시 빌드 검증 관련해서 좋다고 생각합니다! 추가로, 빌드 검증 뿐이라 성능쪽 이슈는 없긴 하겠지만 self hosted runner 말고 github runner 사용한 이유가 따로 있을까요? |
@ga111o 두번째 부분은 이전에 방화벽이 꺼져서 액션이 무제한 펜딩되다 꺼지는 일도 있었고, |
Change Build fail review action 'REQUEST_CHANGES' to 'COMMENT' Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
3 participants
Summary
Motivation
Approach
nothing to comment (just build -> check)
Type of Change
Testing
Checklist
Summary by CodeRabbit