fix(skills): add format step to quality gate and args rule to storybook stories#3914
Open
desiree-np wants to merge 1 commit intomainfrom
Open
fix(skills): add format step to quality gate and args rule to storybook stories#3914desiree-np wants to merge 1 commit intomainfrom
desiree-np wants to merge 1 commit intomainfrom
Conversation
Contributor
✅ No New Circular DependenciesNo new circular dependencies detected. Current count: 0 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the packages/react agent “skills” documentation to better match current CI expectations by adding formatting to the quality gate workflow and documenting a Storybook typing pitfall for render-only stories.
Changes:
- Add a new Format step (
pnpm format && pnpm format:check) as the first Phase 1 command inf0-quality-gate. - Remove
.mdxfrom quality-gate skip candidates and add guidance that MDX must pass formatting checks. - Document a new Storybook rule: render-only stories must explicitly provide
argsto satisfyStorytyping when meta has required props.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/react/.skills/f0-storybook-stories/SKILL.md | Updates story examples formatting and adds a rule about args for render-only stories. |
| packages/react/.skills/f0-quality-gate/SKILL.md | Adds a format step to Phase 1 and expands Storybook review instructions to include MDX documentation checks. |
Comment on lines
+22
to
+24
| import type { Meta, StoryObj } from "@storybook/react-vite"; | ||
| import { fn, expect, within } from "storybook/test"; | ||
| import { withSnapshot, withSkipA11y } from "@/lib/storybook-utils/parameters"; |
Comment on lines
+38
to
+41
| } satisfies Meta<typeof F0Example>; | ||
|
|
||
| export default meta | ||
| type Story = StoryObj<typeof meta> | ||
| export default meta; | ||
| type Story = StoryObj<typeof meta>; |
Comment on lines
20
to
+25
| **Skip when:** | ||
|
|
||
| - The user explicitly says to skip checks | ||
| - The change is documentation-only (`.md`, `.mdx` files, comments) | ||
| - The change is icon generation or other auto-generated files | ||
|
|
||
| > **Note:** `.mdx` files are NOT skip candidates — they go through `oxfmt` formatting and must pass `format:check`. |
Comment on lines
+211
to
216
| You are a Storybook and documentation reviewer for the F0 React component library. | ||
|
|
||
| Load the `f0-storybook-stories` skill from `.skills/f0-storybook-stories/SKILL.md`. | ||
| Load the `f0-storybook-testing` skill from `.skills/f0-storybook-testing/SKILL.md`. | ||
| Load the `f0-docs` skill from `.skills/f0-docs/SKILL.md`. | ||
|
|
Contributor
📦 Alpha Package Version PublishedUse Use |
Contributor
🔍 Visual review for your branch is published 🔍Here are the links to: |
Contributor
Coverage Report for packages/react
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm format && pnpm format:checkas step 1a inf0-quality-gate— runs before TypeScript and Lint, applies to all file types including.mdx.mdxfrom the quality gate skip list — MDX files go throughoxfmtand must pass format checkargs" rule tof0-storybook-stories— prevents TS errors when stories use a customrenderwithout inheriting required props from MetaMotivation
Two recurring CI failures in PRs:
oxfmtformat errors on.mdxand.tsxfiles — the quality gate only ranlint, neverformatargs— this pattern wasn't documented anywhereThese skill updates ensure the agent catches and auto-fixes both issues locally before pushing.