Skip to content

fix: adjust delete popup text message on show pages#868

Open
tomrndom wants to merge 1 commit intomasterfrom
fix/show-pages-delete-message
Open

fix: adjust delete popup text message on show pages#868
tomrndom wants to merge 1 commit intomasterfrom
fix/show-pages-delete-message

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented Apr 9, 2026

image

ref: https://app.clickup.com/t/86b96p88h

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Added a delete confirmation dialog with a warning message when users delete pages, requiring verification before the action is completed.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet April 9, 2026 17:45
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86d3f6d8-142a-4a98-87c2-3902ed3284bc

📥 Commits

Reviewing files that changed from the base of the PR and between eeaf437 and 7e0fc3c.

📒 Files selected for processing (2)
  • src/i18n/en.json
  • src/pages/sponsors/show-pages-list-page/index.js

📝 Walkthrough

Walkthrough

This PR adds a localized delete confirmation message for the ShowPagesListPage. A new translation key is introduced and integrated into the MuiTable component's delete dialog to display a custom warning when users attempt to delete pages.

Changes

Cohort / File(s) Summary
i18n Translation
src/i18n/en.json
Added new translation key show_pages.page_delete_warning with a deletion confirmation message.
Component Props
src/pages/sponsors/show-pages-list-page/index.js
Added deleteDialogBody prop to MuiTable component that translates and interpolates the page delete warning message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

Suggested reviewers

  • smarcet

Poem

🐰 A warning before pages take flight,
"Please verify!" we say with care,
Delete dialogs shining bright,
Translation keys handled with flair,
Safety first in every repair! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: adjust delete popup text message on show pages' accurately summarizes the main change: updating the delete confirmation dialog text for the show pages feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/show-pages-delete-message

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant