Skip to content

feat: add customized page delete for sponsot pages tab#869

Open
tomrndom wants to merge 1 commit intomasterfrom
feature/delete-customized-pages
Open

feat: add customized page delete for sponsot pages tab#869
tomrndom wants to merge 1 commit intomasterfrom
feature/delete-customized-pages

Conversation

@tomrndom
Copy link
Copy Markdown

@tomrndom tomrndom commented Apr 9, 2026

ref: https://app.clickup.com/t/86b8r6wcn

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • New Features
    • Added ability to delete customized sponsor pages with automatic list refresh and success confirmation.

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet April 9, 2026 20:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 478c6ad0-b679-4cbe-909a-eec0659b25b2

📥 Commits

Reviewing files that changed from the base of the PR and between b0c6bd0 and 4cff9e6.

📒 Files selected for processing (2)
  • src/actions/sponsor-pages-actions.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js

📝 Walkthrough

Walkthrough

This PR adds delete functionality for sponsor customized pages by introducing a new action type constant and thunk creator, refactoring existing thunks to remove unnecessary nesting levels, and wiring the delete action into the sponsor-pages-tab component.

Changes

Cohort / File(s) Summary
Action Creators & Constants
src/actions/sponsor-pages-actions.js
Added SPONSOR_CUSTOMIZED_PAGE_DELETED constant and deleteSponsorCustomizedPage(pageId) thunk that dispatches loading states, makes DELETE request, emits action, and displays success snackbar. Refactored getSponsorManagedPages and getSponsorCustomizedPages to remove extra async wrapping level.
UI Integration
src/pages/sponsors/sponsor-page/tabs/sponsor-pages-tab/index.js
Integrated deleteSponsorCustomizedPage action into component; replaced console logging placeholder with actual delete call followed by list refresh with current filters and pagination settings.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • smarcet
  • romanetar

Poem

🐰 A page deleted, clean and neat,
No more console logs—the flow's complete!
With loading states and snackbar cheer,
Sponsor pages vanish without fear! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title refers to a real part of the changeset (adding delete functionality for customized pages), but contains a typo ('sponsot' instead of 'sponsor') and is somewhat vague about the scope—it mentions only the tab UI without acknowledging the new action type constant and refactored thunks in the actions file. Correct the typo ('sponsot' → 'sponsor') and consider a more precise title such as 'feat: add customized page delete functionality for sponsor pages' to better reflect the complete change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/delete-customized-pages

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant