Skip to content

Check code coverage in CI #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbg wants to merge 2 commits into
base: main
Choose a base branch
from
+333 −3
Open

Check code coverage in CI #3788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b92d05
Add code coverage analysis using `c8`, with currently met thresholds
mbg Mar 27, 2026
97837dd
Check code coverage in `pr-checks.yml`
mbg Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ jobs:

- name: Run unit tests
if: always()
run: npm test
run: npm run test-coverage

- name: Check code coverage
if: always()
run: npm run coverage
Comment on lines 55 to +61
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage check step is marked if: always(), so it will run even when the preceding test run fails. In that case it may fail due to missing/partial coverage data and add noise on top of the real test failure; consider running the coverage check only when the test-coverage step succeeds (default success()), or give the test step an id and gate on its outcome.

See below for a potential fix:

        id: test-coverage
        if: always()
        run: npm run test-coverage

      - name: Check code coverage
        if: steps.test-coverage.outcome == 'success'

Copilot uses AI. Check for mistakes.

- name: Lint
if: always() && matrix.os != 'windows-latest'
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
node_modules/
# Build output for tests
build/
# Code coverage information
coverage/
# Java build files
.gradle/
*.class
Expand Down
Loading
Loading