[WIP] Add smoke test coverage for Java 25#46
Conversation
|
@copilot work started on this PR, but I observe this message, "The job was not acquired by a runner even after multiple attempts." . I reverted some commits I suspect are related to this problem. Please try again. Make sure to get the |
- Rename existing smoke-test job to smoke-test-jdk17 - Add smoke-test-java25 job using Microsoft JDK 25 - JDK 25 job instructs agent to follow // JDK 25+: marker comments in README Quick Start to enable virtual threads Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edburns
left a comment
There was a problem hiding this comment.
Due to GitHub status of 500-land, doing this manually.
There was a problem hiding this comment.
Pull request overview
Updates the reusable run-smoke-test GitHub Actions workflow to run the repository’s Copilot CLI–driven smoke test under multiple JDK versions, including a new JDK 25 run intended to exercise the JDK 25 virtual-thread code path described in the README Quick Start.
Changes:
- Renames the existing smoke test job to indicate it runs on JDK 17.
- Adds a second smoke test job targeting Microsoft JDK 25 with additional prompt overrides to enable virtual threads and compile with source/target 25.
Comments suppressed due to low confidence (1)
.github/workflows/run-smoke-test.yml:65
- New job id does not match the issue requirement. The issue asks for a net-new job named
smoke-test-jdk-25, but this workflow definessmoke-test-java25. Please rename the job id tosmoke-test-jdk-25(and keep naming consistent with the JDK 17 job).
smoke-test-java25:
name: Build SDK and run smoke test (JDK 25)
runs-on: ubuntu-latest
| smoke-test-jdk17: | ||
| name: Build SDK and run smoke test (JDK 17) | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Job id does not match the issue requirement. The issue specifies renaming the existing job to smoke-test-jdk-17, but this workflow defines smoke-test-jdk17 (missing the - before 17). Please rename the job id to exactly smoke-test-jdk-17 to align with the requested invariant naming.
This issue also appears on line 63 of the same file.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.