Skip to content

[WIP] Add smoke test coverage for Java 25#46

Merged
edburns merged 2 commits intomainfrom
copilot/add-smoke-test-jdk-25
Mar 31, 2026
Merged

[WIP] Add smoke test coverage for Java 25#46
edburns merged 2 commits intomainfrom
copilot/add-smoke-test-jdk-25

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 31, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>[FEAT]: Make it so the run-smoke-test workflow has added coverage to run the smoke test on Java 25</issue_title>
<issue_description>### Describe the need

Consider .github/workflows/run-smoke-test.yml.

This workflow imperatively causes the smoke test specified in .github/workflows/run-smoke-test.yml to be run, with several, ✅✅extremely important✅✅ overrides so that the test is appropriate in the context of a CI/CD test.

The assignee of this issue must make an additive change to .github/workflows/run-smoke-test.yml so that the JDK 25 Virtual Thread specific behavior is also smoke tested.

Here are some invariant high level guides to the assginee.

  1. Existing job smoke-test must be renamed smoke-test-jdk-17.

  2. Create a net-new job, smoke-test-jdk-25.

    1. This job is largely a copy/paste of smoke-test-jdk-17 but with the following changes.

      • Run with the Microsoft JDK 25. ❌❌NOT temurin❌❌.

      • Extremely important ✅✅additional✅✅ Critical override statements.

        • Tell the agent to heed the "comment/uncomment" instructions in the Quick Start section of the top level README that have the literal prefix "// JDK 25+:"

          • These changes will make the resultant CopilotSDK class exercise the Java 25 Virtual Thread code path.
        • Make it so these comment/uncomment changes happen before building the jar whose main is CopilotSDK.

The topic branch name for this work must include the issue number for this issue.

SDK Version

0.2.1

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct</issue_description>

Comments on the Issue (you are @copilot in this section)

@edburns
Copy link
Copy Markdown
Collaborator

edburns commented Mar 31, 2026

@copilot work started on this PR, but I observe this message, "The job was not acquired by a runner even after multiple attempts." . I reverted some commits I suspect are related to this problem.

Please try again. Make sure to get the HEAD of main before resuming work.

- Rename existing smoke-test job to smoke-test-jdk17
- Add smoke-test-java25 job using Microsoft JDK 25
- JDK 25 job instructs agent to follow // JDK 25+: marker
  comments in README Quick Start to enable virtual threads

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to GitHub status of 500-land, doing this manually.

@edburns edburns marked this pull request as ready for review March 31, 2026 20:24
Copilot AI review requested due to automatic review settings March 31, 2026 20:24
@edburns edburns merged commit 5b09a51 into main Mar 31, 2026
7 checks passed
@edburns edburns deleted the copilot/add-smoke-test-jdk-25 branch March 31, 2026 20:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable run-smoke-test GitHub Actions workflow to run the repository’s Copilot CLI–driven smoke test under multiple JDK versions, including a new JDK 25 run intended to exercise the JDK 25 virtual-thread code path described in the README Quick Start.

Changes:

  • Renames the existing smoke test job to indicate it runs on JDK 17.
  • Adds a second smoke test job targeting Microsoft JDK 25 with additional prompt overrides to enable virtual threads and compile with source/target 25.
Comments suppressed due to low confidence (1)

.github/workflows/run-smoke-test.yml:65

  • New job id does not match the issue requirement. The issue asks for a net-new job named smoke-test-jdk-25, but this workflow defines smoke-test-java25. Please rename the job id to smoke-test-jdk-25 (and keep naming consistent with the JDK 17 job).
    smoke-test-java25:
        name: Build SDK and run smoke test (JDK 25)
        runs-on: ubuntu-latest

Comment on lines +14 to 16
smoke-test-jdk17:
name: Build SDK and run smoke test (JDK 17)
runs-on: ubuntu-latest
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job id does not match the issue requirement. The issue specifies renaming the existing job to smoke-test-jdk-17, but this workflow defines smoke-test-jdk17 (missing the - before 17). Please rename the job id to exactly smoke-test-jdk-17 to align with the requested invariant naming.

This issue also appears on line 63 of the same file.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT]: Make it so the run-smoke-test workflow has added coverage to run the smoke test on Java 25

3 participants