fix(plugins): add view_prefix to avoid BQ analytics view name collisions#5107
Draft
caohy1988 wants to merge 2 commits intogoogle:mainfrom
Draft
fix(plugins): add view_prefix to avoid BQ analytics view name collisions#5107caohy1988 wants to merge 2 commits intogoogle:mainfrom
caohy1988 wants to merge 2 commits intogoogle:mainfrom
Conversation
…ame collisions (google#5099) When multiple BigQueryAgentAnalyticsPlugin instances write to different tables in the same dataset, their auto-created analytics views overwrite each other because view names are derived only from event type. This adds a configurable view_prefix field (default "v") so multi-table users can set distinct prefixes to avoid collisions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
Response from ADK Triaging Agent Hello @caohy1988, thank you for your contribution! It looks like the Contributor License Agreement (CLA) check has failed. Before we can merge this pull request, you'll need to sign the CLA. Please check the details from the Thank you! |
adk-bot
added
the
services
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
view_prefixfield toBigQueryLoggerConfig(default"v") so that multiple plugin instances sharing a dataset can use distinct prefixes to avoid overwriting each other's auto-created analytics viewsview_prefixis non-empty at init timeview_prefixinto_create_analytics_viewsin place of the hardcoded"v_"prefixFixes #5099
Test plan
test_custom_view_prefix— custom prefix changes all view namestest_default_view_prefix_preserves_names— default"v"keeps backward-compatible namestest_distinct_tables_and_prefixes_no_collision— two plugins with different tables/prefixes produce disjoint views pointing at correct tablestest_empty_view_prefix_raises— empty prefix rejected withValueErrortest_config_create_views_default_true— updated to assert defaultview_prefix == "v"🤖 Generated with Claude Code