Open
Conversation
Fix information disclosure or denial of service due to uninitialized variables in gssapi-keyex Based on https://src.fedoraproject.org/rpms/openssh/c/f595270c4ac496ad743336e80a4f3cc11a144efb?branch=rawhide by Zoltan Fridrich <zfridric@redhat.com>
Member
Author
|
Untested so far. Also still unclear if the GSI functionality is affected. |
fscheiner
commented
Apr 12, 2026
| if (kex->dh == NULL) { | ||
| sshpkt_disconnect(ssh, "Protocol error: no matching group found"); | ||
| fatal("Protocol error: no matching group found"); | ||
| ssh_packet_disconnect(ssh, "Protocol error: no matching group found"); |
Member
Author
There was a problem hiding this comment.
@msalle : Here I wonder if that is enough, as the original code did end - I guess the key exchange - with fatal() at this point. But the change by Red Hat has it that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix information disclosure or denial of service due to uninitialized variables in gssapi-keyex
Based on https://src.fedoraproject.org/rpms/openssh/c/f595270c4ac496ad743336e80a4f3cc11a144efb?branch=rawhide by Zoltan Fridrich zfridric@redhat.com