Fix data connector body nullable and replace Slack examples#432
Merged
ellicenelson merged 1 commit intomainfrom Mar 31, 2026
Merged
Fix data connector body nullable and replace Slack examples#432ellicenelson merged 1 commit intomainfrom
ellicenelson merged 1 commit intomainfrom
Conversation
VedranZoricic
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The OpenAPI spec incorrectly marks the data connector
bodyfield asnullable: true, but the API returns""(empty string) when unset — notnull. This causes SDK code generators to produce incorrect nullable types. Example data also referenced Slack unnecessarily.How?
Remove
nullable: truefrom thebodyfield in all 3 data connector schemas (create_data_connector_request,update_data_connector_request,data_connector_detail). Replace "Slack Notification Service" examples with "Order Status Service".Companion PRs
Generated with Claude Code