Add OKLab and Oklch image utilities and nodes, refactor color space nodes#8999
Open
JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
Open
Add OKLab and Oklch image utilities and nodes, refactor color space nodes#8999JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
JPPhoto wants to merge 3 commits intoinvoke-ai:mainfrom
Conversation
Collaborator
Author
|
@dwringer Mind playing with composition nodes here to see if they do what they used to? I made a lot of changes to their internals and fixed what I believe was a bug while I was at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added shared OKLab/OKLCH and related color-conversion utilities, a new
unsharp_mask_oklabimage node, and a newimg_hue_adjust_oklchimage node. The PR also consolidates color-conversion logic into the shared backend module, exports the public helpers throughinvokeai.invocation_apifor custom nodes, standardizes public hue contracts to degrees for polar/hue-based spaces, and regenerates frontend API types/schema.This PR also fixes an existing
Oklchblend bug incomposition-nodes:mainwas treatingOklchhue inconsistently and wrapping it like a unit-range value in some blend paths. The refactor standardizesOklchhue to degrees throughout the shared/public conversion path and updates blend wrapping accordingly, soOklchblend results may differ slightly frommainwhere the old behavior was incorrect.Related Issues / Discussions
QA Instructions
pytest tests/backend/image_util/test_color_conversion.py tests/app/invocations/test_image.py -qMerge Plan
Checklist
What's Newcopy (if doing a release after this PR)