ci: add timeout-minutes to scheduled/update workflow jobs#3550
ci: add timeout-minutes to scheduled/update workflow jobs#3550Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Fixes knative#3546 Scheduled workflows had no timeout-minutes, meaning a hung job would block a runner indefinitely. Follows the pattern from knative#3535 which added timeouts to functions.yaml. - test-podman-next: 60m (full cluster integration test) - update-builder: 30m - update-python-platform: 30m - update-quarkus-platform: 30m - update-springboot-platform: 30m - update-ca-bundle: 15m
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Adds explicit job-level timeouts to scheduled/update GitHub Actions workflows to prevent hung runs from occupying runners indefinitely, aligning these workflows with the timeout pattern introduced in #3535 and addressing #3546.
Changes:
- Added
timeout-minutesto thetestjob intest-podman-next.yaml(60 minutes). - Added
timeout-minutesto multipleupdatejobs across platform update workflows (30 minutes, or 15 for CA bundle). - Added
timeout-minutesto thebuild-and-push-imagejob inupdate-builder.yaml(30 minutes).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-podman-next.yaml | Adds a 60-minute timeout to the scheduled Podman Next test job to prevent indefinite runner usage. |
| .github/workflows/update-builder.yaml | Adds a 30-minute timeout to the scheduled builder image update job to cap runtime. |
| .github/workflows/update-python-platform.yaml | Adds a 30-minute timeout to the scheduled Python platform update job to avoid hung runs. |
| .github/workflows/update-quarkus-platform.yaml | Adds a 30-minute timeout to the scheduled Quarkus platform update job to avoid hung runs. |
| .github/workflows/update-springboot-platform.yaml | Adds a 30-minute timeout to the scheduled Spring Boot platform update job to avoid hung runs. |
| .github/workflows/update-ca-bundle.yaml | Adds a 15-minute timeout to the scheduled CA bundle update job to avoid hung runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3550 +/- ##
==========================================
+ Coverage 55.52% 56.24% +0.71%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11510 +147
+ Misses 7902 7755 -147
Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #3546
Scheduled workflows had no
timeout-minutes, meaning a hung job would block a runner indefinitely. Follows the pattern from #3535 which added timeouts tofunctions.yaml.test-podman-next.yamlupdate-builder.yamlupdate-python-platform.yamlupdate-quarkus-platform.yamlupdate-springboot-platform.yamlupdate-ca-bundle.yaml