Skip to content

ci: add timeout-minutes to scheduled/update workflow jobs#3550

Open
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/add-timeout-minutes
Open

ci: add timeout-minutes to scheduled/update workflow jobs#3550
Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Ankitsinghsisodya:ci/add-timeout-minutes

Conversation

@Ankitsinghsisodya
Copy link
Copy Markdown
Contributor

Closes #3546

Scheduled workflows had no timeout-minutes, meaning a hung job would block a runner indefinitely. Follows the pattern from #3535 which added timeouts to functions.yaml.

Workflow timeout
test-podman-next.yaml 60m
update-builder.yaml 30m
update-python-platform.yaml 30m
update-quarkus-platform.yaml 30m
update-springboot-platform.yaml 30m
update-ca-bundle.yaml 15m

Fixes knative#3546

Scheduled workflows had no timeout-minutes, meaning a hung job would
block a runner indefinitely. Follows the pattern from knative#3535 which added
timeouts to functions.yaml.

- test-podman-next: 60m (full cluster integration test)
- update-builder: 30m
- update-python-platform: 30m
- update-quarkus-platform: 30m
- update-springboot-platform: 30m
- update-ca-bundle: 15m
Copilot AI review requested due to automatic review settings April 1, 2026 07:27
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ankitsinghsisodya
Once this PR has been reviewed and has the lgtm label, please assign lkingland for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and jrangelramos April 1, 2026 07:27
@knative-prow knative-prow bot added size/XS 🤖 PR changes 0-9 lines, ignoring generated files. needs-ok-to-test 🤖 Needs an org member to approve testing labels Apr 1, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 1, 2026

Hi @Ankitsinghsisodya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit job-level timeouts to scheduled/update GitHub Actions workflows to prevent hung runs from occupying runners indefinitely, aligning these workflows with the timeout pattern introduced in #3535 and addressing #3546.

Changes:

  • Added timeout-minutes to the test job in test-podman-next.yaml (60 minutes).
  • Added timeout-minutes to multiple update jobs across platform update workflows (30 minutes, or 15 for CA bundle).
  • Added timeout-minutes to the build-and-push-image job in update-builder.yaml (30 minutes).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/test-podman-next.yaml Adds a 60-minute timeout to the scheduled Podman Next test job to prevent indefinite runner usage.
.github/workflows/update-builder.yaml Adds a 30-minute timeout to the scheduled builder image update job to cap runtime.
.github/workflows/update-python-platform.yaml Adds a 30-minute timeout to the scheduled Python platform update job to avoid hung runs.
.github/workflows/update-quarkus-platform.yaml Adds a 30-minute timeout to the scheduled Quarkus platform update job to avoid hung runs.
.github/workflows/update-springboot-platform.yaml Adds a 30-minute timeout to the scheduled Spring Boot platform update job to avoid hung runs.
.github/workflows/update-ca-bundle.yaml Adds a 15-minute timeout to the scheduled CA bundle update job to avoid hung runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.24%. Comparing base (e92b074) to head (bb1fb0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
+ Coverage   55.52%   56.24%   +0.71%     
==========================================
  Files         180      180              
  Lines       20465    20465              
==========================================
+ Hits        11363    11510     +147     
+ Misses       7902     7755     -147     
  Partials     1200     1200              
Flag Coverage Δ
e2e 36.11% <ø> (-4.07%) ⬇️
e2e go 32.55% <ø> (ø)
e2e node 28.36% <ø> (ø)
e2e python 32.91% <ø> (ø)
e2e quarkus 28.48% <ø> (ø)
e2e rust 27.92% <ø> (ø)
e2e springboot 26.32% <ø> (-0.04%) ⬇️
e2e typescript 28.47% <ø> (ø)
e2e-config-ci 18.14% <ø> (ø)
integration 17.40% <ø> (+<0.01%) ⬆️
unit macos-14 43.37% <ø> (ø)
unit macos-latest 43.37% <ø> (ø)
unit ubuntu-24.04-arm 43.57% <ø> (ø)
unit ubuntu-latest 44.25% <ø> (ø)
unit windows-latest 43.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test 🤖 Needs an org member to approve testing size/XS 🤖 PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: add timeout-minutes to scheduled/update workflow jobs

2 participants