ci: add concurrency groups to scheduled/update workflows#3551
ci: add concurrency groups to scheduled/update workflows#3551Ankitsinghsisodya wants to merge 1 commit intoknative:mainfrom
Conversation
Fixes knative#3547 Without a concurrency group, a new scheduled run starts even if the previous one is still in progress, wasting runner minutes. Follows the pattern from knative#3536 which added concurrency to functions.yaml.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ankitsinghsisodya The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
size/S
|
Hi @Ankitsinghsisodya. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions concurrency controls to scheduled/update workflows to prevent overlapping runs (which can waste runner minutes and race on auto-generated PR creation), aligning with the prior pattern introduced in functions.yaml (#3536).
Changes:
- Add
concurrency.group: ${{ github.workflow }}-${{ github.ref }}to the affected scheduled/update workflows. - Enable
cancel-in-progress: trueso newer scheduled/manual runs supersede older in-progress runs for the same workflow+ref.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test-podman-next.yaml | Adds concurrency group to prevent overlapping scheduled podman-next test runs. |
| .github/workflows/update-builder.yaml | Adds concurrency to avoid redundant hourly builder image update runs. |
| .github/workflows/update-python-platform.yaml | Adds concurrency to avoid overlapping platform update runs that can create duplicate PRs. |
| .github/workflows/update-quarkus-platform.yaml | Adds concurrency to prevent overlapping Quarkus platform update runs. |
| .github/workflows/update-springboot-platform.yaml | Adds concurrency to prevent overlapping Spring Boot platform update runs. |
| .github/workflows/update-ca-bundle.yaml | Adds concurrency to prevent overlapping CA bundle update runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3551 +/- ##
==========================================
+ Coverage 55.52% 56.23% +0.71%
==========================================
Files 180 180
Lines 20465 20465
==========================================
+ Hits 11363 11509 +146
+ Misses 7902 7756 -146
Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #3547
Without a
concurrencygroup, if a scheduled run is still in progress when the next one fires both run simultaneously, wasting runner minutes and potentially creating duplicate PRs. Follows the pattern from #3536 which added concurrency tofunctions.yaml.Affected workflows:
test-podman-next,update-builder,update-python-platform,update-quarkus-platform,update-springboot-platform,update-ca-bundle.