Skip to content

[release-1.21] Remember --registry-insecure setting on recurring runs#3574

Open
creydr wants to merge 2 commits intoknative:release-1.21from
creydr:cp-remember-registry-insecure-flag-1.21
Open

[release-1.21] Remember --registry-insecure setting on recurring runs#3574
creydr wants to merge 2 commits intoknative:release-1.21from
creydr:cp-remember-registry-insecure-flag-1.21

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 2, 2026

Cherry-pick of #3490

creydr and others added 2 commits April 2, 2026 16:10
@creydr
Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (k…
0ed84a8 
…native#3484)

When --registry-insecure is used, set tlsVerify=false in the Tekton
pipeline to allow buildah to push to registries with self-signed certs.
@creydr @gauron99
Remember --registry-insecure setting on recurring runs (knative#3490)
105fe56 
* Revert "Pass --registry-insecure flag to Tekton pipeline tlsVerify parameter (knative#3484)"

This reverts commit da21fa2.

* Remember `--registry-insecure` setting on recurring runs

* Run `make schema-generate`

* Simplify parsing

* Extend description of flag, that values are persited

* Add warning, when registry changed but insecure-registry is still set to true

* Fix typo

* Rerun update-codegen

* Cleanup test names

* Add unit test for WarnRegistryInsecureChange

* Run schema-generate

* Update pkg/functions/client.go

Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>

* Update pkg/functions/client.go

Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>

* Update pkg/config/config.go

Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>

* Update pkg/config/config.go

Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>

* Fix format issues (goimport and gofmt)

* Refactor registry-insecure unit test to make it available for the Deploy tests too

* Refactor GlobalConfig.WarnRegistryInsecureChange() method to function in cmd package

---------

Co-authored-by: David Fridrich <49119790+gauron99@users.noreply.github.com>
@knative-prow knative-prow bot requested a review from dsimansk April 2, 2026 14:17
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: creydr
Once this PR has been reviewed and has the lgtm label, please assign linkvt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from jrangelramos April 2, 2026 14:17
@knative-prow knative-prow bot added the size/XL 🤖 PR changes 500-999 lines, ignoring generated files. label Apr 2, 2026
@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 2, 2026

/cherry-pick release-1.20

@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Apr 2, 2026

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 2, 2026

/cc @gauron99

@knative-prow knative-prow bot requested a review from gauron99 April 2, 2026 14:17
@gauron99
Copy link
Copy Markdown
Contributor

gauron99 commented Apr 2, 2026

@creydr pls regenerate docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@gauron99 gauron99 Awaiting requested review from gauron99

Assignees

No one assigned

Labels

size/XL 🤖 PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@creydr @knative-prow-robot @gauron99