fix: host builder passes environment variables to spawned subprocesses#3577
Open
gauron99 wants to merge 1 commit intoknative:mainfrom
Open
fix: host builder passes environment variables to spawned subprocesses#3577gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99 wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
+ Coverage 53.77% 56.26% +2.49%
==========================================
Files 180 180
Lines 20465 20483 +18
==========================================
+ Hits 11005 11525 +520
+ Misses 8354 7755 -599
- Partials 1106 1203 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
force-pushed
the
push-xwxrtyspwuot
branch
2 times, most recently
from
97588a6 to
01c4816
Compare
The runPython() and runGo() functions in runner.go were setting cmd.Env by appending to a nil slice, which discarded the parent environment and any func.yaml/CLI environment variables. Now both functions inherit the parent process environment via os.Environ() and inject Run.Envs using Interpolate(), matching the behavior of container-based builders.
gauron99
force-pushed
the
push-xwxrtyspwuot
branch
from
01c4816 to
e302a7c
Compare
gauron99
commented
Apr 3, 2026
| ) | ||
|
|
||
| const ( | ||
| defaultRunHost = "127.0.0.1" // TODO allow to be altered via a runOpt |
Contributor
Author
There was a problem hiding this comment.
just removing the comment, we are already parsing the address
gauron99
commented
Apr 4, 2026
Comment on lines
+173
to
+179
| cmd.Cancel = func() error { | ||
| if runtime.GOOS == "windows" { | ||
| // Interrupt is not implemented on windows apparently | ||
| return cmd.Process.Kill() | ||
| } | ||
| return cmd.Process.Signal(os.Interrupt) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
the new Cancel function.
Windows apparently does not implement safer interrupt so we have to Kill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runPython() and runGo() functions in runner.go were setting cmd.Env by appending to a nil slice, which discarded the parent environment and any func.yaml/CLI environment variables. Now both functions inherit the parent process environment via os.Environ() and inject Run.Envs using Interpolate(), matching the behavior of container-based builders.