feat(ModuleNotifier): Add Module to get feedback in chat when modules toggle#258
Open
IceTank wants to merge 3 commits intolambda-client:1.21.11from
Open
feat(ModuleNotifier): Add Module to get feedback in chat when modules toggle#258IceTank wants to merge 3 commits intolambda-client:1.21.11from
IceTank wants to merge 3 commits intolambda-client:1.21.11from
Conversation
IceTank
changed the title
beanbag44
requested changes
Mar 12, 2026
Contributor
Author
|
I refactored the ModuleNotifier so it listens to events produced by the module when toggling |
beanbag44
requested changes
Mar 17, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
I dont know, just assuming but if portions of this pr and others are written with ai, please try to clean up the code (unused imports, old comments, etc), and test it to make sure it has the desired outcome
src/main/kotlin/com/lambda/module/modules/client/ModuleNotifier.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lambda/module/modules/client/ModuleNotifier.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/lambda/module/modules/client/ModuleNotifier.kt
Outdated
Show resolved
Hide resolved
Remove redundant toggle listen in ModuleNotifier Clean up code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds chat feedback when modules toggle