feat: add library enum constants for Kolibri and Community libraries#215
Merged
rtibbles merged 2 commits intolearningequality:mainfrom Apr 13, 2026
Merged
Conversation
Adds spec/constants-library.json with KOLIBRI and COMMUNITY enum values. Generated le_utils/constants/library.py and js/Library.js via generate_from_specs.py. test: simplify LIBRARYLIST test assertion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rtibbles
reviewed
Apr 13, 2026
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
This is great, can you also bump the version so we can make a new release?
Contributor
Author
|
Done — added a CHANGELOG entry for v0.2.17 in 0c3197a. After this merges, tagging |
rtibbles
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: Add a
libraryenum to le-utils that identifies whether a channel belongs to the Kolibri Library or the Community Library, with generated Python and JavaScript constant files.Summary
Adds a
libraryenum withKOLIBRIandCOMMUNITYvalues for identifying which library a channel belongs to. The spec file (spec/constants-library.json) drives generation of the Python and JavaScript constants via the existing generator script.References
Closes #214
Related: learningequality/studio#5821
Reviewer guidance
Run
uv run pytest tests/test_library.py -vto verify the generated constants. No risky areas — purely additive change following an established pattern.AI usage
Used Claude Code to implement following a pre-approved plan. Wrote failing tests first, created the spec, ran the generator, verified all tests pass.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?