Open
Conversation
Changed focus_aw and focus_ah from deg to rad to comply with randvec_target_angular.
Added both component to contrib and test instrument to examples
Author
Contributor
|
@SSBNS I’ve started looking at your component which looks mostly nice - I have done a little my self by now:
There are a few remaining things I would like you to rectify before inclusion:
Will take another look at your instr file also. |
Contributor
|
Oh and yes one more thing - it looks like you may have (by mistake, likely) touched Phonon_simple also, will put the version from main in place to keep things as clear as possible. |
* Remove commented monitor-instances * Remove -n specifiers in %Example lines * Add <sup>-1</sup> html syntax in header
Contributor
|
I did minor rectifications to the instr header also + removed “dead” comp instances |
Contributor
|
… and finally I have run the |
Contributor
|
Another addition to the wish-list:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
I am adding the SpinWave_BCO component to the sample library. as well as a test instrument in examples.
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
I developed and tested on Windows
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution includes a new component file
mcdocutility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)mccode-clangformattool to apply the standard McCode component indentation schemecontribcomponent categoryMy contribution includes a new instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)%Example:line to describe expected behaviourmcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedexampleshierarchy in a folder in the style ofexamples/ESS/New_stuff/New_stuff.instr