Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…in attack history
…ype hints where its redundant
446c643 to
69d038f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Converter Panel” to the PyRIT GUI so users can discover prompt converters, configure basic parameters, preview outputs, and apply one converter per modality per turn, with supporting backend endpoints and test coverage.
Changes:
- Backend: added a converter “catalog” API (types + supported IO + simple parameter schema) and enhanced preview to support non-text data types.
- Frontend: implemented the ConverterPanel UI (tabs by modality, parameter form, preview + “use converted value”) and integrated it into ChatWindow/ChatInputArea send flow.
- Tests: added/updated unit tests (backend + frontend) and introduced Playwright e2e coverage for converter workflows.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/backend/test_converter_service.py | Adds unit tests for the new converter catalog service method and updates preview-chain expectation. |
| tests/unit/backend/test_api_routes.py | Adds route-level test for /api/converters/catalog. |
| pyrit/backend/services/converter_service.py | Implements converter catalog generation (doc/params introspection), param coercion, and enhanced preview handling for media types. |
| pyrit/backend/services/attack_service.py | Ensures atomic_attack_identifier stays consistent when per-message converters update the attack identifier. |
| pyrit/backend/routes/converters.py | Adds a new GET /converters/catalog endpoint. |
| pyrit/backend/models/converters.py | Introduces DTOs for catalog entries and parameter schemas. |
| frontend/src/types/index.ts | Adds TS types for converter catalog and converter instances. |
| frontend/src/services/api.ts | Adds convertersApi client functions (catalog/create/preview/etc.). |
| frontend/src/components/Config/TargetConfig.test.tsx | Adds dialog cancel/close test coverage. |
| frontend/src/components/Config/CreateTargetDialog.test.tsx | Makes target creation test input method consistent. |
| frontend/src/components/Chat/converterTypes.ts | Adds shared mapping/types for piece-type ↔ data-type and conversion payloads. |
| frontend/src/components/Chat/ConverterPanel.tsx | New converter panel UI: selection, param editing, preview, auto-preview behavior, and “use converted value”. |
| frontend/src/components/Chat/ConverterPanel.test.tsx | Unit tests for converter panel UI behaviors (selection, params, preview, resizing, etc.). |
| frontend/src/components/Chat/ConverterPanel.styles.ts | Styles for the converter panel per repo convention. |
| frontend/src/components/Chat/ChatWindow.tsx | Integrates converter panel state + applies conversions into outgoing message requests. |
| frontend/src/components/Chat/ChatWindow.test.tsx | Adds integration tests covering converter panel toggling and preview flow in chat. |
| frontend/src/components/Chat/ChatInputArea.tsx | Adds converter toggle button, “converted” UI rows, and attachment→base64 propagation to converter panel. |
| frontend/src/components/Chat/ChatInputArea.test.tsx | Expands unit tests for converter toggle, converted UI, and attachment conversion indicators. |
| frontend/src/components/Chat/ChatInputArea.styles.ts | Layout updates for converted/original display and attachment rows. |
| frontend/package.json | Adds react-async-hook and bumps frontend version. |
| frontend/package-lock.json | Lockfile updates for new dependency/version bump. |
| frontend/e2e/converters.spec.ts | New Playwright e2e suite covering converter panel flows. |
| frontend/e2e/chat.spec.ts | Improves mocked message GET handling and skips a flaky/overbroad video role query test. |
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding converter panels to the GUI interface! This PR only lets you run ONE converter per turn per type of media (ie you can do an image + text conversion in same turn but not two text conversions in one turn)
Tests and Documentation
Images:

(new button is shown):
(new panel)

(panel dropdown)

(once you've selected converter)

(tabs for different modalities of converters - you can have 1 per mode per turn)
