Open
Conversation
| return { message, stackLines, location }; | ||
| } | ||
|
|
||
| export function errorLocationFromStack(error: Error | undefined, pathSeparator: string, showInternalStackFrames: boolean = false): { |
Member
There was a problem hiding this comment.
This code works for Node.js (V8), it does not work for errors in WebKit / Firefox.
Contributor
Author
There was a problem hiding this comment.
The new test passes for all browser. So I am not sure what to do?
Collaborator
There was a problem hiding this comment.
I think we should plumb the location all the way from the browser-specific protocol event to here. It should be already available in the protcol.
Member
There was a problem hiding this comment.
@cpAdm web error originates from the web page. That web page runs in the browser, it can be Firefox or WebKit. You can't parse Firefox error text in Node and assume it is coming from V8 - stack frame format is different.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConsoleMessage.location()Closes: #39687