perf: Defer black import to first use#229
Conversation
uv 0.10.x is current; the <0.10.0 constraint caused build warnings.
parse_azure_endpoint returned the raw URL including ?api-version=... which AsyncAzureOpenAI then mangled into invalid paths like ...?api-version=2024-06-01/openai/. Strip the query string before returning — api_version is already returned as a separate value and passed to the SDK independently.
black is only used in create_context_prompt() and format_code() -- both cold paths. Moving the import inside the functions avoids loading black and its transitive deps (pathspec, black.nodes, etc.) on every import typeagent.
gvanrossum
left a comment
There was a problem hiding this comment.
Should have one this a long time ago. :-(
|
Thanks, wasn't sure you wanted import time optimizations, if you do, I have a few more ready to go. |
|
This one is dear to my heart because I wish we could remove black from the mandatory dependencies. Happy to review more. |
|
why can't you remove black? out of curiousness |
I could, but it gives the nicest formatted expressions when doing hardcore debugging. What we could do is import it conditionally and just use repr() if black cannot be imported. Then we can remove it from the main deps. Developers have the dev tools installed (pyright, black, isort, pytest, etc.) and will see the black-formatted debug output. |
|
Went ahead and did this — #235 replaces |
Stack: 2/4 — depends on #231. Merge #231 first, then this PR.
import blackfrom module level to first use inanswers.pyandutils.pyblack(code formatter + transitive deps: pathspec, black.nodes, etc.) loaded on everyimport typeagentbut only used in two cold formatting pathsblack.format_str()is called in two places:create_context_prompt()inknowpro/answers.py— formats debug context for LLM promptsformat_code()inaitools/utils.py— developer pretty-print utilityNeither runs during normal library operation. Moving the import inside each function eliminates ~78ms of transitive module loading from the import chain.
Benchmark
Azure Standard_D2s_v5 — 2 vCPU, 8 GiB RAM, Python 3.13
Import Time (hyperfine, warmup 5, min-runs 30)
import typeagentOffline E2E Test Suite (hyperfine, warmup 2, min-runs 10)
Generated by codeflash optimization agent