Skip to content

fix(test-activity): prevent tooltip overflow on small viewports (@Mubashir21)#7821

Open
Mubashir21 wants to merge 1 commit intomonkeytypegame:masterfrom
Mubashir21:fix/test-activity-tooltip-overflow
Open

fix(test-activity): prevent tooltip overflow on small viewports (@Mubashir21)#7821
Mubashir21 wants to merge 1 commit intomonkeytypegame:masterfrom
Mubashir21:fix/test-activity-tooltip-overflow

Conversation

@Mubashir21
Copy link
Copy Markdown

Description

Bug: On small/mobile viewports, the activity calendar tooltips near the left and right edges get clipped by the viewport boundary because the tooltip position was hardcoded to "up" for every cell.

Fix: After the cells are rendered, I measure the actual tooltip width using a hidden probe element with the same font styles as the balloon tooltip. For each cell, I use getBoundingClientRect() to check if the tooltip would overflow the left or right edge of the viewport. If it would, the position is switched to "up-left" or "up-right" accordingly. A ResizeObserver on the container recalculates positions on every resize, so it works correctly at any viewport width.

Steps to reproduce: Go to /account, shrink the browser window to mobile width, hover over cells on the left or right edge of the activity calendar: the tooltip gets cut off.

Checks

  • Adding quotes?
    • Make sure to follow the quotes documentation
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.
image image

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants