fix(sftp): flush synchronously added requests during connection cleanup#1491
Open
jeffrson wants to merge 1 commit intomscdex:masterfrom
Open
fix(sftp): flush synchronously added requests during connection cleanup#1491jeffrson wants to merge 1 commit intomscdex:masterfrom
jeffrson wants to merge 1 commit intomscdex:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1490
Problem
cleanupRequests() runs once when the channel closes and calls all pending _requests callbacks with an error. However, some callbacks (notably the high-level readdir error path) synchronously register new entries in _requests via this.close(handle, cb). These new entries are never flushed — the channel is already non-readable, so push(null) and therefore cleanupRequests will not fire again. The user-supplied callback is silently dropped.
Fix
Replace the single-pass cleanup with a loop that keeps flushing until _requests is stably empty:
The loop terminates because callback chains are finite (typical depth: readdir → close → user callback → done). The err object is created once outside the loop to avoid redundant allocations.
The "reproducer" at https://github.com/jeffrson/ssh2-missing-cb finally executes the callback in client when this patch is used.