Edit pyproject.toml file's tool.uv.sources option if it is a uv-managed project#81
Edit pyproject.toml file's tool.uv.sources option if it is a uv-managed project#81jensens merged 21 commits intomxstack:mainfrom
tool.uv.sources option if it is a uv-managed project#81Conversation
Co-authored-by: Steve Piercy <web@stevepiercy.com>
jensens
left a comment
There was a problem hiding this comment.
Feature concept is sound but needs rework in a few areas before merge. See inline comments.
|
Thank you both for the review, I have updated the code to match your review notes. |
|
Gemini suggested doing the |
jensens
left a comment
There was a problem hiding this comment.
Most prior issues addressed well. One critical ordering bug remains, plus a few smaller items.
jensens
left a comment
There was a problem hiding this comment.
Looks good. All critical issues addressed. Minor simplification opportunities remain (the TYPE_CHECKING dance at runtime, the triple-layer managed check, bare except on tomllib) — we can clean those up in a follow-up.
For uv-managed projects (those with
[tool.uv] managed=trueinpyproject.toml) write in the[tool.uv.sources]option of thepyproject.tomlthe paths to the downloaded packages.See erral/mxdev-uv-pyproject-updater#1 and plone/cookieplone-templates#352 for reference