Skip to content

fix: SonarCloud quality gate issues#9793

Draft
solracsf wants to merge 9 commits intomasterfrom
fixSonarIssues
Draft

fix: SonarCloud quality gate issues#9793
solracsf wants to merge 9 commits intomasterfrom
fixSonarIssues

Conversation

@solracsf
Copy link
Copy Markdown
Member

@solracsf solracsf commented Apr 3, 2026

Addresses some of the SonarCloud quality gate issues.

@solracsf solracsf force-pushed the fixSonarIssues branch 4 times, most recently from 8066fdf to 1e572eb Compare April 3, 2026 14:59
solracsf added 9 commits April 4, 2026 09:00
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
…nt return type

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Artifact containing the AppImage: nextcloud-appimage-pr-9793.zip

Digest: sha256:eec2b63cd5ea5667d17cc04c1e1683133a13781bd0ffefa5a6fd68a8b574673c

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)


bool maybeRenameForWindowsCompatibility(const QString &absoluteFileName,
CSYNC_EXCLUDE_TYPE excludeReason);
bool maybeRenameForWinCompatibility(const QString &absoluteFileName,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ modernize-use-nodiscard ⚠️
function maybeRenameForWinCompatibility should be marked [[nodiscard]]

Suggested change
bool maybeRenameForWinCompatibility(const QString &absoluteFileName,
[[nodiscard]] bool maybeRenameForWinCompatibility(const QString &absoluteFileName,

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
70.7% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
49 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant