Skip to content

chore(learn): move to dedicated repo#8757

Merged
ovflowd merged 5 commits intomainfrom
learn-migration
Apr 2, 2026
Merged

chore(learn): move to dedicated repo#8757
ovflowd merged 5 commits intomainfrom
learn-migration

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Mar 23, 2026

Closes: #8612
Blocked-by: Setting up nodejs/learn

Moves all learn references to https://learn.nodejs.org.

cc @nodejs/TSC

Copilot AI review requested due to automatic review settings March 23, 2026 22:08
@avivkeller avivkeller requested review from a team as code owners March 23, 2026 22:08
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Apr 2, 2026 6:56pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra @nodejs/nodejs-website @nodejs/diagnostics

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.23%. Comparing base (621b579) to head (ba8f04b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8757      +/-   ##
==========================================
- Coverage   75.28%   74.23%   -1.06%     
==========================================
  Files         105      105              
  Lines        9247     8870     -377     
  Branches      328      328              
==========================================
- Hits         6962     6585     -377     
  Misses       2283     2283              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves the Learn section out of this repository by removing Learn content/layouts/navigation and redirecting Learn routes to the new dedicated site at https://learn.nodejs.org.

Changes:

  • Remove Learn page content and the Learn-specific layout/navigation/i18n entries from this repo.
  • Update site navigation and add redirects to route /learn/* traffic to https://learn.nodejs.org/*.
  • Clean up ancillary repo metadata related to Learn (Crowdin ignore entries, CODEOWNERS, issue template, contributing text).

Reviewed changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/i18n/src/locales/en.json Removes Learn sidebar navigation translation keys.
crowdin.yml Removes Learn-page ignore patterns (Learn content removed from repo) and normalizes top-level YAML formatting.
apps/site/types/layouts.ts Removes learn from the Layouts union.
apps/site/redirects.json Redirects /learn/* and /:locale/learn/* to https://learn.nodejs.org/* and removes several prior Learn/guides-related redirects.
apps/site/pages/en/learn/typescript/transpile.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/typescript/run.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/typescript/run-natively.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/typescript/publishing-a-ts-package.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/typescript/introduction.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/test-runner/mocking.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/test-runner/introduction.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/modules/publishing-node-api-modules.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/modules/abi-stability.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/writing-files-with-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/working-with-folders-in-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/working-with-file-descriptors-in-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/working-with-different-filesystems.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/reading-files-with-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/nodejs-file-stats.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/manipulating-files/nodejs-file-paths.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/http/enterprise-network-configuration.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/websocket.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/userland-migrations.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/the-v8-javascript-engine.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/profiling.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/nodejs-with-webassembly.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/nodejs-the-difference-between-development-and-production.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/introduction-to-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/fetch.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/ecmascript-2015-es6-and-beyond.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/differences-between-nodejs-and-the-browser.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/debugging.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/getting-started/an-introduction-to-the-npm-package-manager.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/user-journey.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/poor-performance/using-linux-perf.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/poor-performance/index.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/memory/using-heap-snapshot.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/memory/using-heap-profiler.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/memory/understanding-and-tuning-memory.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/memory/index.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/live-debugging/using-inspector.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/live-debugging/index.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/diagnostics/flame-graphs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/command-line/run-nodejs-scripts-from-the-command-line.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/command-line/output-to-the-command-line-using-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/command-line/how-to-use-the-nodejs-repl.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/command-line/how-to-read-environment-variables-from-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/command-line/accept-input-from-the-command-line-in-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/understanding-setimmediate.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/understanding-processnexttick.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/the-nodejs-event-emitter.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/overview-of-blocking-vs-non-blocking.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/javascript-asynchronous-programming-and-callbacks.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/discover-promises-in-nodejs.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/discover-javascript-timers.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/learn/asynchronous-work/asynchronous-flow-control.md Removes Learn article (moved to dedicated Learn repo/site).
apps/site/pages/en/about/get-involved/index.md Updates “official learning materials” link to https://learn.nodejs.org/.
apps/site/navigation.json Points top-nav Learn link to https://learn.nodejs.org and removes Learn side navigation tree.
apps/site/layouts/Learn.tsx Removes Learn layout component.
apps/site/components/withLayout.tsx Removes Learn layout registration.
CONTRIBUTING.md Removes explicit mention of “learn articles” from contribution bullets.
.github/ISSUE_TEMPLATE/03-article-issue.yml Removes Learn-article issue template.
.github/CODEOWNERS Removes Learn-content CODEOWNERS entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.52 MB
New Total Size 3.51 MB
Delta -12.63 KB (-0.35%)

Changes

➕ Added Assets (1)
Name Size
.next/static/chunks/29614162a36f1355.js 197.56 KB
➖ Removed Assets (1)
Name Size
.next/static/chunks/e91da22bf2673103.js 210.19 KB

@flakey5
Copy link
Copy Markdown
Member

flakey5 commented Mar 24, 2026

Blocked-by: nodejs/admin#1050

I'm assuming this pr is also blocked on getting the subdomain setup for learn.nodejs.org?

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 24, 2026

Blocked-by: nodejs/admin#1050

I'm assuming this pr is also blocked on getting the subdomain setup for learn.nodejs.org?

Do we need that subdomain? I'm pretty sure we can wire it to nodejs.org/learn to keep the existing URLs working, no? I wouldn't like needing to actually add yet another layer of redirects from existing nodejs.org/en/learn to --> something else.

But ultimately fine with it.

@styfle
Copy link
Copy Markdown
Member

styfle commented Mar 24, 2026

Yeah seems like it would be better to keep the existing url.

Checkout https://vercel.com/docs/microfrontends

@MattIPv4
Copy link
Copy Markdown
Member

MattIPv4 commented Mar 24, 2026

I don't think we'll need any Vercel functionality to support this, it'll just be an origin rule in Cloudflare to route /learn to whatever deployment the new repo has, similar to how we route specific routes (/docs, /dist, etc.) away from Vercel currently to the origin server.

@avivkeller
Copy link
Copy Markdown
Member Author

Blocked by: nodejs/learn#1

@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Mar 29, 2026

Blocked by: nodejs/learn#1

Still blocked?

@avivkeller
Copy link
Copy Markdown
Member Author

Still blocked?

IMO we shouldn't remove any content from here until that repo is 100% set up and deployed as a replacement

Copy link
Copy Markdown
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

Copy link
Copy Markdown
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd ovflowd enabled auto-merge April 2, 2026 19:05
@ovflowd ovflowd disabled auto-merge April 2, 2026 19:06
@ovflowd ovflowd merged commit b9a16f3 into main Apr 2, 2026
14 checks passed
@ovflowd ovflowd deleted the learn-migration branch April 2, 2026 19:06
@ovflowd
Copy link
Copy Markdown
Member

ovflowd commented Apr 2, 2026

@nodejs/web-infra @nodejs/nodejs-website fast-tracking so we can start using the new learn stuff and verify performance by using doc-kit and see errors/issues if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Move Learn content to a dedicated nodejs/learn repository

7 participants