You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
The PR failed bc u don't have the last Protobuf package of gobgp. In fact, the function GetUnidirectionalLinkDelay() is not defined..
Is only defined on the last commit (https://github.com/osrg/gobgp/commit/e13c9f7814c4c8e02377b5cd4f1213708a5b53bd) which is not on the v4.2.0 release
@geforcebtw Thank you for the PR! LGTM. GetUnidirectionalLinkDelay() is not in GoBGP v4.2.0, so the build fails.
We’ll merge this after the next GoBGP release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding UnidirectionalLinkDelay metric support due to the commit changes osrg/gobgp@e13c9f7#diff-cb276724b7a01394c8eebc87ff78663f28a82263ae882fd480c798849934ed39
Type of change
Motivation and Context
This change required the last compiled protobuf gobgp and adding the capabilities of Pola to dump the METRIC_TYPE_DELAY.