Skip to content

Adding UnidirectionalLinkDelay metric support#291

Merged
watal merged 2 commits intonttcom:developfrom
geforcebtw:develop
Mar 31, 2026
Merged

Adding UnidirectionalLinkDelay metric support#291
watal merged 2 commits intonttcom:developfrom
geforcebtw:develop

Conversation

@geforcebtw
Copy link
Copy Markdown
Contributor

@geforcebtw geforcebtw commented Feb 26, 2026

Description

Adding UnidirectionalLinkDelay metric support due to the commit changes osrg/gobgp@e13c9f7#diff-cb276724b7a01394c8eebc87ff78663f28a82263ae882fd480c798849934ed39

Type of change

  • New features
  • Bug fixes
  • Refactoring
  • Documentation updates

Motivation and Context

This change required the last compiled protobuf gobgp and adding the capabilities of Pola to dump the METRIC_TYPE_DELAY.

@geforcebtw
Copy link
Copy Markdown
Contributor Author

Hi,
The PR failed bc u don't have the last Protobuf package of gobgp. In fact, the function GetUnidirectionalLinkDelay() is not defined..
Is only defined on the last commit (https://github.com/osrg/gobgp/commit/e13c9f7814c4c8e02377b5cd4f1213708a5b53bd) which is not on the v4.2.0 release

@watal
Copy link
Copy Markdown
Member

watal commented Feb 27, 2026

@geforcebtw Thank you for the PR! LGTM.
GetUnidirectionalLinkDelay() is not in GoBGP v4.2.0, so the build fails.
We’ll merge this after the next GoBGP release.

@watal
Copy link
Copy Markdown
Member

watal commented Mar 2, 2026

@geforcebtw GoBGP v4.3.0 has been merged into the Pola PCE develop branch.
Could you please follow the steps below before we proceed with the merge?

  1. In the root directory of pola, run:
go fmt ./...

Then squash the formatting changes into commit 62fa91e.

  1. Rebase your branch onto pola:develop:
git remote add upstream https://github.com/nttcom/pola.git
git fetch upstream
git rebase upstream/develop
  1. After rebasing, please verify that it works correctly with GoBGP v4.3.0.

@watal
Copy link
Copy Markdown
Member

watal commented Mar 31, 2026

Hi @geforcebtw,
Just a friendly reminder to rebase your branch onto pola:develop (with GoBGP v4.3.0) and run go fmt ./....

Once updated, we can proceed with the merge.

Thanks!

@geforcebtw
Copy link
Copy Markdown
Contributor Author

Hi @watal
Sorry for the delay. I hope is good for you !
Have a nice day :)

@watal watal merged commit 680f8a8 into nttcom:develop Mar 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants