NE-2520: Promote GatewayAPIWithoutOLM to GA

[gcs278]

This PR promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default (GA).

Background

The GatewayAPIWithoutOLM feature replaces the OLM-based Istio installation method with direct Helm chart installation via the Sail library, enabling Gateway API support on clusters without OLM/Marketplace capabilities and avoiding conflicts with existing OSSM subscriptions.

Related Work

• Enhancement: NE-2470: Gateway API without OLM
• Implementation: cluster-ingress-operator#1354
• Jira Epic: NE-2520

Testing

• Sippy: GatewayAPIWithoutOLM Results
• Existing E2E tests adapted in cluster-ingress-operator gateway_api_test.go for more coverage
• Upgrade test: origin#30897 validates OLM to NO-OLM migration; tested manually (TechPreview clusters cannot be upgraded in CI), will merge soon and shouldn't block promotion

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE: Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8e7ffeb7-bd69-46ed-8274-abcaf9bdf489

📥 Commits

Reviewing files that changed from the base of the PR and between 64340c4 and 71580b7.

📒 Files selected for processing (6)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

✅ Files skipped from review due to trivial changes (1)

• features.md

🚧 Files skipped from review as they are similar to previous changes (3)

• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

📝 Walkthrough

Walkthrough

The GatewayAPIWithoutOLM feature gate is enabled in additional contexts. The feature gate registration in features/features.go now includes inDefault() and inOKD() alongside inDevPreviewNoUpgrade() and inTechPreviewNoUpgrade(). Corresponding payload feature-gate YAMLs for Hypershift and SelfManagedHA (Default and OKD variants) move GatewayAPIWithoutOLM from status.featureGates[].disabled to status.featureGates[].enabled. features.md reorders the GatewayAPIWithoutOLM row in the feature table.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c6220410-2306-11f1-9c3a-90af7c7cc380-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23e6af60-2307-11f1-992d-12ede9d2e079-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/26a088fc-2307-11f1-9da4-6bca82f01e76-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e01ef8c0-2309-11f1-813c-239011e41911-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0198a9d0-233f-11f1-9a7d-ebebc862b301-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/07dadcd0-2391-11f1-8c59-fe2512e5aad1-0

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ab81910-23c6-11f1-8635-bf728c1f5aad-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1e4a3720-2406-11f1-93e5-9f16732fd0e5-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ddd5ec0-2493-11f1-8cf8-effe9a495bea-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/69a77f80-24c8-11f1-9403-ad1a7c99fb97-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8a761690-24c8-11f1-9c74-da2cb51d6692-0

[openshift-ci-robot]

@gcs278: This pull request references NE-2561 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

WIP DO NOT MERGE (yet): Using this for testing

This change promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default Feature Set (GA).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d5568f0-2710-11f1-9d03-561b26d4f2f7-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7c1b46a0-2979-11f1-9476-ac2dbf9a0ed8-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ad0efd0-297a-11f1-95c5-290d9ec10095-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61957ad0-29e2-11f1-9921-6bbab26a3719-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/322df070-2bc1-11f1-9068-51d08a5996e8-0

[openshift-ci-robot]

@gcs278: This pull request references NE-2520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR promotes the GatewayAPIWithoutOLM feature gate from TechPreviewNoUpgrade to Default (GA).

Background

The GatewayAPIWithoutOLM feature replaces the OLM-based Istio installation method with direct Helm chart installation via the Sail library, enabling Gateway API support on clusters without OLM/Marketplace capabilities and avoiding conflicts with existing OSSM subscriptions.

Related Work

• Enhancement: NE-2470: Gateway API without OLM
• Implementation: cluster-ingress-operator#1354
• Jira Epic: NE-2520

Testing

• Sippy: GatewayAPIWithoutOLM Results
• Existing E2E tests adapted in cluster-ingress-operator gateway_api_test.go for more coverage
• Upgrade test: origin#30897 validates OLM to NO-OLM migration; tested manually (TechPreview clusters cannot be upgraded in CI), will merge soon and shouldn't block promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

@gcs278 Quick scan of your results, you have no vSphere, SNO or metal testing at all presently. Is there a particular reason that this feature isn't applicable to any/all of those variants?

[gcs278]

@JoelSpeed We don't support Gateway API on SNO. For vsphere and metal - we are introducing support for baremetal in this pending release (4.22) via NE-2010. For context, we only added testing, no implementation needed.

For our vsphere/baremetal testing, we use the pre-submit job e2e-vsphere-static-metallb-operator-gwapi in the CIO repo, though it's not configured for TechPreview. The testing was added as a pre-submit and not in origin E2E, the current [OCPFeatureGate:GatewayAPIWithoutOLM] origin E2Es don't run on vsphere because we need a metalLB-capable job.

Both this feature and NE-2010 are important for us in 4.22. Once this merges, the e2e-vsphere-static-metallb-operator-gwapi pre-submit will immediately validate the GA feature. @rikatz can speak up on what he thinks about the promotion timeline, and whether we can accept the risk of promotion with limit vsphere/metal testing. And I'm curious on what you think @JoelSpeed too.

Either way, I could have been a bit more proactive in either creating a e2e-vsphere-static-metallb-operator-gwapi-techpreview job or manually running it to have some data ready, that's my fault. In the meantime, I can try to trigger a pj-rehearse on the pre-submit vsphere job to validate it's working:

/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-operator-gwapi

[gcs278]

Whoops, I think I need to use the payload-job command:
/payload-job pull-ci-openshift-cluster-ingress-operator-master-e2e-vsphere-static-metallb-operator-gwapi

[openshift-ci]

@gcs278: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

[gcs278]

I've added a PR for running the metal/vsphere techpreview Gateway API jobs, my hope is that we can use our pre-submit rehearsals to prove it won't break metal/vsphere: openshift/release#77188

[gcs278]

Update: we added vsphere/metal testing in openshift/origin#30946.

For SNO, I was slightly incorrect, we do support it. And we do actually test on it. It was a bug: the last run of verify-feature-promotion shows that #2789 fixed this signal.

So now we wait for vsphere and metal.

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a4e3ff40-2ec0-11f1-8605-18a4784240eb-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade-paused

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/254dfd70-2ec1-11f1-8462-20ffaf2d891d-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-vsphere-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/215f4c30-2ec3-11f1-976f-5d98aff4f8c1-0

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-e2e-metal-ipi-ovn-upgrade
• periodic-ci-openshift-release-main-nightly-4.22-upgrade-from-stable-4.21-e2e-metal-ipi-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a0b13bf0-2ec9-11f1-9fc6-7f338c200f2a-0

[gcs278]

Should have our first vsphere/metal tests, I know it will fail, but let me confirm the signal:
/test verify-feature-promotion

[gcs278]

INSUFFICIENT CI testing for "GatewayAPIWithoutOLM".
F0403 13:00:29.215010   10945 root.go:64] Error running codegen: error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure GatewayClass contains CIO management conditions after creation [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure GatewayClass contains sail finalizer after creation [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure Istio CRDs are managed by CIO and istiod deployment exists [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure Sail operator resources are not installed [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure istiod Deployment contains the correct label [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure GatewayClass contains CIO management conditions after creation [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv4   false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure GatewayClass contains sail finalizer after creation [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv4   false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure Istio CRDs are managed by CIO and istiod deployment exists [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv4   false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure Sail operator resources are not installed [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv4   false}
error: "[sig-network-edge][OCPFeatureGate:GatewayAPIController][Feature:Router][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure istiod Deployment contains the correct label [Suite:openshift/conformance/parallel]" only has 2 runs, need at least 14 runs for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv4   false}
error: only 0 tests found, need at least 5 for "GatewayAPIWithoutOLM" on {metal amd64 ha ipv6   false}
error: only 0 tests found, need at least 5 for "GatewayAPIWithoutOLM" on {metal amd64 ha dual   false}

Looking good for vsphere and metal. We don't support dual stack/IPv6, see openshift/origin#30942

[gcs278]

Just curious on how many tests are being reported now:
/test verify-feature-promotion

[everettraven]

We don't support dual stack/IPv6, see openshift/origin#30942

Looks like the linked PR only removes support for dual stack, not IPv6 - just to make sure, we are certain we do not support ipv6 networking for this feature?

[everettraven]

whether we can accept the risk of promotion with limit vsphere/metal testing.

My general stance is that if we have (or should have) signal for a platform, we shouldn't be promoting until the criteria are met. If the promotion is urgent, the OpenShift architects and the BU are the ones that need to make the decision on whether or not a promotion goes through without sufficient testing via an SBAR.

In this case, I'd say lets just collect the runs. If you need extra runs you can use the gangway cli (https://github.com/openshift-eng/gangway-cli) to trigger more job runs.

[openshift-ci]

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	71580b7	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gcs278]

Looks like the linked PR only removes support for dual stack, not IPv6 - just to make sure, we are certain we do not support ipv6 networking for this feature?

Yes, I'm certain. Though we do claim support for Metal/VSphere (NE-2010), we do not claim support for IPv6 and DualStack for the entire Gateway API feature. We don't run tests on it today, and when I tried to enable it for IPv6, Gateway API doesn't work. And my feature (GatewayAPIWithoutOLM) is a "child feature" that is dependent on Gateway API functioning.

In this case, I'd say lets just collect the runs. If you need extra runs you can use the gangway cli (https://github.com/openshift-eng/gangway-cli) to trigger more job runs.

Agreed, I added them last week in openshift/origin#30946 (I forgot to link here). We are getting signal now, but it looks like we are at 87% for Vsphere for this specific test (2/16 flaked):

][apigroup:gateway.networking.k8s.io] [OCPFeatureGate:GatewayAPIWithoutOLM] Ensure GatewayClass contains sail finalizer after creation [Suite:openshift/conformance/parallel]" only passed 87%, need at least 95% for "GatewayAPIWithoutOLM" on {vsphere amd64 ha    false}

The 2 flakes are due to the test hardness code for markTestDone (not the actual test). It's a classic "object has been modified" because the CIO now writes conditions to the GatewayClass, causing a conflict with the test harness code when it tries to write an annotation as a test-completion marker:

{  fail [github.com/openshift/origin/test/extended/router/gatewayapicontroller.go:1132]: Unexpected error:
    <*errors.StatusError | 0xc0096d74a0>: 
    Operation cannot be fulfilled on gatewayclasses.gateway.networking.k8s.io "openshift-default": the object has been modified; please apply your changes to the latest version and try again
    {
        ErrStatus: 
            code: 409
            details:
              group: gateway.networking.k8s.io
              kind: gatewayclasses
              name: openshift-default
            message: 'Operation cannot be fulfilled on gatewayclasses.gateway.networking.k8s.io
              "openshift-default": the object has been modified; please apply your changes to
              the latest version and try again'
            metadata: {}
            reason: Conflict
            status: Failure,
    }
occurred}

I have a fix up here for it openshift/origin#30964.

@JoelSpeed @everettraven would you consider allowing us to promote? I did the math, and we'd need 24 more tests to succeed in a row to get back to 95%. I don't think we have quite that runway at the moment. I could gangway the Vsphere tests, but it'd seem a bit hard on our VSphere resources (i'd need to run 6-7 times a day to get in by branch cut). I'm confident the VSphere feature functionality is working as expected.

To summarize the verify-feature-promotion failures:

• IPv6 and DualStack are not supported for Gateway API, and GatewayAPIWithoutOLM depends on Gateway API functioning.
• A new VSphere test is flaking at 87% (2/16) due to a test harness conflict, not a product bug. Fix is up: OCPBUGS-81751: Fix GatewayClass update conflict in markTestDone origin#30964.

Please let me know if you'd need anything from me.