SPLAT-2320: Bump openshift/api

[Phaow]

• Follow up of SPLAT-2320: vsphere vm-host zonal ga api#2731, after the api promote GA we need to bump the openshift/api.

[openshift-ci-robot]

@Phaow: This pull request references SPLAT-2320 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

• Follow up of SPLAT-2320: vsphere vm-host zonal ga api#2731, after the api promote GA we also need to remove the feature gate validation for install config.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Zonal host-VM-group affinity logic in vSphere manifests now runs unconditionally for failure domains with ZoneType == vsphere.HostGroupFailureDomain; the corresponding feature-gate validation entry was removed; and multiple dependency versions in go.mod were upgraded.

Changes

Cohort / File(s)	Summary
vSphere host VM group logic pkg/asset/manifests/vsphere/infrastructure.go	Removed the feature-gate check so for failureDomain.ZoneType == vsphere.HostGroupFailureDomain the code always sets failureDomainSpec.RegionAffinity and failureDomainSpec.ZoneAffinity (includes HostGroup from topology and VMGroup/VMHostRule derived from clusterID and failureDomain.Name).
Feature-gate validation pkg/types/vsphere/validation/featuregates.go	Deleted the FeatureGateVSphereHostVMGroupZonal entry from GatedFeatures, removing its condition that inspected failure domains and the now-unused vsphere import.
Dependency updates go.mod	Updated versions for multiple modules (notable github.com/openshift/api, k8s.io/*, golang.org/x/*, and various indirect deps); no replace directives changed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pkg/asset/manifests/vsphere/infrastructure.go`:
- Around line 55-67: The code unconditionally sets
failureDomainSpec.RegionAffinity and failureDomainSpec.ZoneAffinity for
HostGroupFailureDomain (see failureDomain.ZoneType,
vsphere.HostGroupFailureDomain, failureDomainSpec.RegionAffinity/ZoneAffinity
and types configv1.VSphereFailureDomainRegionAffinity/ZoneAffinity), which
violates the vendored API validation guarded by the VSphereHostVMGroupZonal
feature gate; update the installer to only populate these fields when the
VSphereHostVMGroupZonal gate is enabled (i.e., add a conditional check for the
feature gate before assigning RegionAffinity/ZoneAffinity and
HostGroup/VMGroup/VMHostRule), otherwise omit those fields until the API is
promoted or the vendor bump removes the gate.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4f661bab-aa80-48cb-b753-b1a2e3b9ff0f

📥 Commits

Reviewing files that changed from the base of the PR and between 3fa9ca0 and 30e030f.

📒 Files selected for processing (2)

• pkg/asset/manifests/vsphere/infrastructure.go
• pkg/types/vsphere/validation/featuregates.go

💤 Files with no reviewable changes (1)

• pkg/types/vsphere/validation/featuregates.go

[Phaow]

Hi @jcpowermac @sgaoshang , could you help take a look when you get a chance? Thank you! ^^

[Phaow]

/assign @jcpowermac @sgaoshang

[Phaow]

I could see with the cluster-bot pre build payload with the fix install(without setting tp featuregate) succeed in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/77055/rehearse-77055-periodic-ci-openshift-release-main-nightly-4.22-e2e-vsphere-ovn-host-groups-csi/2039241660986036224 .

[sgaoshang]

@WenXinWei pls have a look.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jcpowermac. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@Phaow: This pull request references SPLAT-2320 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

• Follow up of SPLAT-2320: vsphere vm-host zonal ga api#2731, after the api promote GA we need to bump the openshift/api.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Phaow]

/retitle SPLAT-2320: Bump openshift/api

[jcpowermac]

/lgtm

[Phaow]

/retest-required

[openshift-ci]

@Phaow: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/azure-ovn-marketplace-images	5317408	link	false	/test azure-ovn-marketplace-images
ci/prow/e2e-azure-ovn-shared-vpc	5317408	link	false	/test e2e-azure-ovn-shared-vpc
ci/prow/e2e-azure-default-config	5317408	link	false	/test e2e-azure-default-config
ci/prow/e2e-vsphere-ovn-hybrid-env	65824ca	link	false	/test e2e-vsphere-ovn-hybrid-env
ci/prow/e2e-vsphere-multi-vcenter-ovn	65824ca	link	false	/test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-aws-ovn	b7e2850	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[WenXinWei]

/lgtm

[Phaow]

@WenXinWei If you have verified passed for the bump, could you please help add /verified by XX label? Thank you! ^^