Open
Conversation
Created using jj-spr 0.1.0
papertigers
commented
Apr 6, 2026
| /// This MUST be called when reseting the virtio-socket device so | ||
| /// that we don't use stale `GuestAddr`s across device resets. | ||
| pub(crate) fn clear_rx_chain(&mut self) { | ||
| self.rx_chain = None; |
Contributor
Author
There was a problem hiding this comment.
In the future I would like to eliminate this RxPermit by possibly extending the VirtQueue to allow peek() or a method that checks if the chain has a descriptor available.
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
VsockPollerevent loop so that it complies with theLifecycletrait within propolis.The virtio device now requests a pause to the event-loop by sending a
VsockEvent::Pauseviaport_send(3C).When the event loop receives this event it finishes processing any tasks and then waits on a mpsc channel. This channel is responsible for processing follow up events driven by the virtio device lifecycle such as resume, reset, and halt. The reset event takes care of cleaning up all state internal to
VsockPollerin addition to removing the cached descriptor chain inVsockVq. It's important we drop this cached descriptor as using it across device resets would cause propolis to scribble data into a random location in guest memory depending on where theGuestAddrpoints.Finally with this work in place it should make solving #1065 trivial.