Conversation
* Make the button a matching div * Tweak capitalization to make it more flexible * Add role: 'button'
* Basically the next render would be often broken...
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f78a30c9b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (this.diff != null) { | ||
| this.computedLang = | ||
| this.diff?.lang ?? getFiletypeFromFileName(this.diff.name); |
There was a problem hiding this comment.
initializeHighlighter() now overwrites this.computedLang from this.diff, which can still point to the previously rendered diff when renderDiff() kicks off asyncHighlight(diff) for a new file/language. In that flow, the wrong language gets loaded into the shared highlighter, and the subsequent highlight pass for the new diff can fail (or stay plain-text) when that language was not already attached. This is a functional regression in non-worker rendering when switching across file types.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in the next commit
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
This updates the docs and examples to better reflect our intentions around custom hunk separators.
Mostly deprecating the raw custom hunk api, remove old broken docs, and help explain how a custom css variant is the preferred way to go, with both visual and code examples.