Skip to content

Fix terminal color contrast#1781

Open
chungweileong94 wants to merge 1 commit intopingdotgg:mainfrom
chungweileong94:main
Open

Fix terminal color contrast#1781
chungweileong94 wants to merge 1 commit intopingdotgg:mainfrom
chungweileong94:main

Conversation

@chungweileong94
Copy link
Copy Markdown

@chungweileong94 chungweileong94 commented Apr 6, 2026

What Changed

Fix terminal color contrast issue, mostly colors like black, bright black, white & bright white.

Why

In some cases those colors make things unreadable.

UI Changes

Left = Before
Right = After

image image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: only updates xterm theme RGB values for black/white variants in light and dark modes to improve readability; no behavior or data-flow changes.

Overview
Improves the thread terminal’s readability by adjusting the xterm theme palette for both dark and light modes, specifically tuning black, brightBlack, white, and brightWhite colors to increase contrast.

Reviewed by Cursor Bugbot for commit d386b44. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix terminal color contrast in dark and light modes

Updates color constants for black, white, brightBlack, and brightWhite in the terminalThemeFromApp util in ThreadTerminalDrawer.tsx. No logic changes; only the literal color values are modified.

Macroscope summarized d386b44.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b1f1bfa2-b78c-4c91-a3d7-0e0781302feb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 6, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d386b44. Configure here.

brightMagenta: "rgb(153, 107, 172)",
brightCyan: "rgb(70, 149, 164)",
brightWhite: "rgb(236, 240, 246)",
brightWhite: "rgb(102, 113, 128)",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light theme brightWhite is darker than white

Medium Severity

In the light theme, brightWhite (rgb(102, 113, 128)) is darker than white (rgb(120, 131, 146)), inverting the expected brightness relationship. Every other ANSI color pair in both themes has the "bright" variant lighter than the base variant. This inconsistency will cause unexpected visual results when terminal programs use brightWhite for emphasis — it'll appear dimmer instead of brighter.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d386b44. Configure here.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 6, 2026

Approvability

Verdict: Needs human review

While this is a simple color contrast adjustment, an unresolved review comment identifies a potential bug where brightWhite is darker than white in the light theme, inverting the expected brightness relationship. This should be addressed before merging.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant