Conversation
ApprovabilityVerdict: Needs human review This PR introduces a new Windows-specific custom title bar feature with new UI components, IPC handlers, and cross-cutting changes to multiple existing components. While well-scoped to Windows platform, it introduces new user-facing capability and new renderer-main process communication patterns that warrant human review. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2be07d2. Configure here.
| } | ||
| const fallback = BrowserWindow.getAllWindows().find((entry) => !entry.isDestroyed()); | ||
| return fallback ?? null; | ||
| } |
There was a problem hiding this comment.
Close handler fallback may close wrong window
Medium Severity
The resolveEventWindow helper, used by window IPC handlers, includes a fallback to mainWindow or any other active window if the event sender's window cannot be resolved. For the CLOSE_WINDOW_CHANNEL handler, this fallback can cause an unrelated window to close, risking unexpected data loss.
Reviewed by Cursor Bugbot for commit 2be07d2. Configure here.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |


Summary
What Changed
Screenshots
Testing
bun fmtbun lintbun typecheckNote
Medium Risk
Changes desktop window chrome on Windows to a frameless window and routes minimize/maximize/close through new IPC APIs, which can impact basic window behavior across platforms if miswired. UI updates are mostly conditional to Windows Electron but touch shared layout/header code paths.
Overview
Adds a custom Windows title bar for the Electron desktop app by making Windows windows frameless (
frame: false) and introducingDesktopTitleBar/DesktopWindowControlsin the web UI.Exposes new window-control IPC in the desktop main/preload layers (
minimize,toggleMaximize,close, plusget/onWindowState) backed by a newDesktopWindowStatecontract, and wires Windows-only title bar rendering into chat, diff panel, settings, and index routes while keeping existing drag-region headers for non-Windows Electron. Also tweaks desktop sidebar header padding on Windows to account for the new chrome.Reviewed by Cursor Bugbot for commit 8865c0e. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add custom title bar with window controls for Windows desktop
frame: false) with a newDesktopTitleBarandDesktopWindowControlscomponent replacing the native title barDesktopWindowStatecontractsDesktopTitleBarintoChatView,DiffPanelShell, settings, and index routes on Windows Electron; non-Windows Electron retains existing drag-region headersMacroscope summarized 8865c0e.