fix: use different bundle ID for dev runner#1806
fix: use different bundle ID for dev runner#1806nmggithub wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 862f65c. Configure here.
| const isDevelopment = Boolean(process.env.VITE_DEV_SERVER_URL); | ||
| const APP_DISPLAY_NAME = isDevelopment ? "T3 Code (Dev)" : "T3 Code (Alpha)"; | ||
| const APP_BUNDLE_ID = "com.t3tools.t3code"; | ||
| const APP_BUNDLE_ID = isDevelopment ? "com.t3tools.t3code.dev" : "com.t3tools.t3code"; |
There was a problem hiding this comment.
Stale cache serves old bundle ID without rebuild
Medium Severity
LAUNCHER_VERSION remains at 1 after changing the bundle ID logic. The build cache (expectedMetadata) only checks launcherVersion, source path, source mtime, and icon mtime — not the bundle ID itself. Developers with an existing cached .electron-runtime app bundle won't get a rebuild, so their dev runner will keep the old com.t3tools.t3code bundle ID, defeating the purpose of this change. Bumping LAUNCHER_VERSION to 2 would force a cache invalidation and rebuild.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 862f65c. Configure here.
There was a problem hiding this comment.
Feels a bit weird to do a whole version jump for this, but, given the dev runner is all this file is for (per the comment at the top of it), perhaps it's ok.
ApprovabilityVerdict: Needs human review Simple dev tooling change to separate bundle IDs, but an unresolved review comment correctly identifies that LAUNCHER_VERSION should be bumped to force cache invalidation. Without this fix, existing cached builds won't pick up the new bundle ID. You can customize Macroscope's approvability policy. Learn more. |


What Changed
This just makes our dev runner use a different bundle ID.
Why
macOS expects different apps to have different bundle IDs. When we break this expectation, that may lead to bad side effects. It's hard to say specifically, as the OS likely makes a multitude of decisions based on this in all different areas. Ultimately, we just don't want macOS to confuse our dev runner for our built app or visa versa.
UI Changes
N/A
Checklist
I included before/after screenshots for any UI changesI included a video for animation/interaction changesNote
Low Risk
Low risk: only changes the macOS
CFBundleIdentifierused by the dev launcher to avoid OS-level app identity collisions; runtime behavior should be unaffected aside from app identity.Overview
Updates the desktop Electron launcher to use a different macOS bundle ID in development (
com.t3tools.t3code.dev) while keeping the production bundle ID unchanged.This prevents macOS from treating the dev runner and built app as the same application (and avoids related caching/registration side effects) when patching
Info.plistduring launcher build.Reviewed by Cursor Bugbot for commit 862f65c. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Use a separate bundle ID for the dev Electron runner
In electron-launcher.mjs,
APP_BUNDLE_IDis now set tocom.t3tools.t3code.devin development mode andcom.t3tools.t3codein production. This prevents the dev runner from conflicting with the production app on macOS.Macroscope summarized 862f65c.