Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 17dfcbb. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing typography customization feature with new settings schema types, a new typography module, new React hooks, and settings UI controls. While well-scoped to visual presentation with no security/billing implications, the substantial new capability (700+ additions, multiple new files, new user-facing settings) warrants human review. You can customize Macroscope's approvability policy. Learn more. |

What changed
This adds scoped local typography controls to the web app's existing settings flow.
Why it changed
Typography in the app was mostly hardcoded, which made it impossible to tune the reading experience without editing source. The requested scope was narrower than a full global typography override, so this keeps the controls tied to concrete product surfaces instead of changing every inherited
sansormonosurface in one shot.Impact
Validation
bun fmtbun lintbun typecheckcd apps/web && bun run test src/components/timelineHeight.test.tsNote
Add scoped typography settings for chat, user messages, and code blocks
divinstead ofpre, removing defaultprewhitespace semantics; whitespace handling is now controlled by CSS classes.Macroscope summarized 481b644.
Note
Medium Risk
Touches global CSS variables and chat timeline virtualization height estimates, so regressions could show up as layout/scroll glitches or inconsistent typography across renders. No security- or data-critical logic is changed.
Overview
Adds scoped typography customization via new client settings for UI font family, user message font mode, and chat/code font size + line height, including reset-to-default behavior in Settings.
Typography is applied through root CSS variables (pre-applied on startup to avoid a flash) and new utility hooks/modules (e.g.
typography.ts,useTypographySettings,useAppliedTypographySettings).Chat surfaces are updated to use the new
app-chat-typography/app-user-message-typographyclasses, and timeline row height estimation/virtualizer re-measurement now accounts for the active typography settings (with updated/added tests to cover wrapping changes).Reviewed by Cursor Bugbot for commit 481b644. Bugbot is set up for automated code reviews on this repo. Configure here.