Skip to content

fix: intellij not being visible even though it's installed#1828

Open
tomaspiaggio wants to merge 3 commits intopingdotgg:mainfrom
tomaspiaggio:tomaspiaggio/intellij-open
Open

fix: intellij not being visible even though it's installed#1828
tomaspiaggio wants to merge 3 commits intopingdotgg:mainfrom
tomaspiaggio:tomaspiaggio/intellij-open

Conversation

@tomaspiaggio
Copy link
Copy Markdown

@tomaspiaggio tomaspiaggio commented Apr 7, 2026

What Changed

Small bug not finding Intellij IDEA even though it's installed if the CLI is not present.

I didn't went ahead and implemented windows and linux because the changes would have been much greater and I'm trying to adhere to the small contributions or bugs guideline. I'm up to do it if you want though (I'm not really sure if this is a problem in other platforms). Open to feedback as well.

Why

There's a bug not finding Intellij IDEA on Mac.

UI Changes

Here's the fixed result:
image

As you can see in this image, I have Intellij installed and open (running it with npx t3 so you can see the difference) but it's not visible on the dropdown.

Screenshot 2026-04-07 at 15 35 55

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk, localized to editor detection/launch logic on macOS; main risk is incorrect .app path assumptions causing editors to appear/launch unexpectedly.

Overview
Fixes IntelliJ IDEA not appearing/launching on macOS when its CLI (idea) is not on PATH.

Adds optional appName to editor definitions plus a new isAppInstalled check for /Applications/<app>.app, and updates resolveAvailableEditors/resolveEditorLaunch to fall back to open -a <appName> --args ... when the app bundle exists. Tests are updated/extended to cover the new macOS fallback behavior.

Reviewed by Cursor Bugbot for commit 0a4a35d. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix IntelliJ not appearing in editor list when CLI is missing but app is installed on macOS

  • Adds appName metadata to the IntelliJ IDEA entry in EDITORS and a new isAppInstalled helper that checks for .app bundles in /Applications on macOS.
  • resolveAvailableEditors now includes editors whose .app bundle is detected even when no CLI command is found.
  • resolveEditorLaunch falls back to open -a <AppName> --args ... on macOS when the CLI is unavailable but the .app bundle is present, instead of returning the unavailable CLI command.

Macroscope summarized 0a4a35d.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3b832374-d1f0-44ea-b900-20d14e76b6cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 7, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 7, 2026

Approvability

Verdict: Approved

This is a straightforward bug fix that adds macOS .app bundle detection as a fallback for editor detection. The changes are self-contained to editor launching logic with clear intent. The unresolved review comment is a low-severity concern about test coverage in CI, not a production code issue.

You can customize Macroscope's approvability policy. Learn more.

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0a4a35d. Configure here.

args: ["-a", "IntelliJ IDEA", "--args", "/tmp/workspace"],
});
}),
);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New tests silently pass without any assertions

Low Severity

Both new tests guard all their assertions behind if (!isAppInstalled(idea, "darwin")) return;, which checks the real filesystem for /Applications/IntelliJ IDEA.app. On any non-macOS machine or any macOS machine without IntelliJ installed (i.e., virtually every CI runner), the tests early-return and pass with zero assertions executed. This means the open -a fallback code path has no regression protection in CI. Since isAppInstalled uses raw statSync rather than the Effect FileSystem service, the check can't be mocked via layers either.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0a4a35d. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant