fix: intellij not being visible even though it's installed#1828
fix: intellij not being visible even though it's installed#1828tomaspiaggio wants to merge 3 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This is a straightforward bug fix that adds macOS .app bundle detection as a fallback for editor detection. The changes are self-contained to editor launching logic with clear intent. The unresolved review comment is a low-severity concern about test coverage in CI, not a production code issue. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0a4a35d. Configure here.
| args: ["-a", "IntelliJ IDEA", "--args", "/tmp/workspace"], | ||
| }); | ||
| }), | ||
| ); |
There was a problem hiding this comment.
New tests silently pass without any assertions
Low Severity
Both new tests guard all their assertions behind if (!isAppInstalled(idea, "darwin")) return;, which checks the real filesystem for /Applications/IntelliJ IDEA.app. On any non-macOS machine or any macOS machine without IntelliJ installed (i.e., virtually every CI runner), the tests early-return and pass with zero assertions executed. This means the open -a fallback code path has no regression protection in CI. Since isAppInstalled uses raw statSync rather than the Effect FileSystem service, the check can't be mocked via layers either.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0a4a35d. Configure here.


What Changed
Small bug not finding Intellij IDEA even though it's installed if the CLI is not present.
I didn't went ahead and implemented windows and linux because the changes would have been much greater and I'm trying to adhere to the small contributions or bugs guideline. I'm up to do it if you want though (I'm not really sure if this is a problem in other platforms). Open to feedback as well.
Why
There's a bug not finding Intellij IDEA on Mac.
UI Changes
Here's the fixed result:

As you can see in this image, I have Intellij installed and open (running it with npx t3 so you can see the difference) but it's not visible on the dropdown.
Checklist
Note
Low Risk
Low risk, localized to editor detection/launch logic on macOS; main risk is incorrect
.apppath assumptions causing editors to appear/launch unexpectedly.Overview
Fixes IntelliJ IDEA not appearing/launching on macOS when its CLI (
idea) is not onPATH.Adds optional
appNameto editor definitions plus a newisAppInstalledcheck for/Applications/<app>.app, and updatesresolveAvailableEditors/resolveEditorLaunchto fall back toopen -a <appName> --args ...when the app bundle exists. Tests are updated/extended to cover the new macOS fallback behavior.Reviewed by Cursor Bugbot for commit 0a4a35d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix IntelliJ not appearing in editor list when CLI is missing but app is installed on macOS
appNamemetadata to the IntelliJ IDEA entry inEDITORSand a newisAppInstalledhelper that checks for.appbundles in/Applicationson macOS.resolveAvailableEditorsnow includes editors whose.appbundle is detected even when no CLI command is found.resolveEditorLaunchfalls back toopen -a <AppName> --args ...on macOS when the CLI is unavailable but the.appbundle is present, instead of returning the unavailable CLI command.Macroscope summarized 0a4a35d.