Feature remove duckdb dependencies and fix some bugs#1307
Open
B3377596 wants to merge 5 commits intopixelsdb:masterfrom
Open
Feature remove duckdb dependencies and fix some bugs#1307B3377596 wants to merge 5 commits intopixelsdb:masterfrom
B3377596 wants to merge 5 commits intopixelsdb:masterfrom
Conversation
bianhq
requested changes
Apr 4, 2026
| static constexpr const TableFilterType TYPE = TableFilterType::CONSTANT_COMPARISON; | ||
|
|
||
| public: | ||
| // 使用 std::move 处理可能存在的字符串拷贝 |
| @@ -0,0 +1,45 @@ | |||
| #pragma once | |||
| namespace pixels{ | |||
| //仿照duckdb的比较符结构体，每个结构体都有一个静态函数Operation，接受两个参数，返回比较结果。PixelsFilter.cpp中会调用这个函数来进行过滤操作。 | |||
| @@ -0,0 +1,41 @@ | |||
| #pragma once | |||
Contributor
There was a problem hiding this comment.
Add license header in front of all of the new source files:
/*
* Copyright 2026 PixelsDB.
*
* This file is part of Pixels.
*
* Pixels is free software: you can redistribute it and/or modify
* it under the terms of the Affero GNU General Public License as
* published by the Free Software Foundation, either version 3 of
* the License, or (at your option) any later version.
*
* Pixels is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* Affero GNU General Public License for more details.
*
* You should have received a copy of the Affero GNU General Public
* License along with Pixels. If not, see
* <https://www.gnu.org/licenses/>.
*/| duckdb::TableFilterSet *filter; | ||
| // TODO: pixelsPredicate | ||
| pixels::TableFilterSet filter; | ||
| //修改：不再依赖 duckdb 类型，不过看来原项目的主人是想要设计一套自己的谓词系统的 |
Contributor
There was a problem hiding this comment.
Remove AI-generated content that has no meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Modification.docx