Merged
Conversation
georgestagg
approved these changes
Mar 30, 2026
Collaborator
georgestagg
left a comment
georgestagg
left a comment
There was a problem hiding this comment.
This looks like a great introduction, thanks!
| @@ -0,0 +1,101 @@ | |||
| --- | |||
Collaborator
There was a problem hiding this comment.
Not strictly part of this PR, but in the grammar.qmd page can we add something like a diagram or example, just to break up the text.
I found these types of diagram for ggplot2 helpful, if we can easily make something similar for ggsql:
Collaborator
Author
There was a problem hiding this comment.
Yeah, I certainly want to spruce up that section with a diagram or two
Co-authored-by: George Stagg <georgestagg@gmail.com> Co-authored-by: Thomas Lin Pedersen <thomasp85@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds upon the current Get started section and adds three additional pages for users to familarise themselves with. In addition it contains a range of fixes to bugs I uncovered as I developed the examples (all issues are unsurprisingly confined to the vegalite writer). The issues fixed are: