Skip to content

Fix rendering of control whitespace in completion items#1622

Merged
kmvanbrunt merged 6 commits intomainfrom
sanitize_completion_display
Apr 2, 2026
Merged

Fix rendering of control whitespace in completion items#1622
kmvanbrunt merged 6 commits intomainfrom
sanitize_completion_display

Conversation

@kmvanbrunt
Copy link
Copy Markdown
Member

No description provided.

…sure correct rendering in the completion menu.
@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner April 1, 2026 17:43
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (d404476) to head (288deec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   99.59%   99.57%   -0.03%     
==========================================
  Files          21       21              
  Lines        4715     4721       +6     
==========================================
+ Hits         4696     4701       +5     
- Misses         19       20       +1     
Flag Coverage Δ
unittests 99.57% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tleonhardt
tleonhardt previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tleonhardt
tleonhardt previously approved these changes Apr 1, 2026
@kmvanbrunt kmvanbrunt changed the title Sanitize whitespace characters in CompletionItem display fields Fix rendering of control whitespace in completion items Apr 2, 2026
) # End of group
$ # End of string
""",
re.VERBOSE,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, I didn't know that you could enable this verbose mode and then embed comments in regular expressions and it ignores them! That is a pretty cool feature that really helps document wtf a regex is doing. Thanks. I learned something today ;-)

@kmvanbrunt kmvanbrunt merged commit bf86bd0 into main Apr 2, 2026
32 of 33 checks passed
@kmvanbrunt kmvanbrunt deleted the sanitize_completion_display branch April 2, 2026 03:48
@kmvanbrunt kmvanbrunt restored the sanitize_completion_display branch April 2, 2026 03:48
@kmvanbrunt kmvanbrunt deleted the sanitize_completion_display branch April 2, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants