Target argument for scale, map etc#190
Open
digikar99 wants to merge 2 commits intoquil-lang:masterfrom
Open
Conversation
YarinHeffes
suggested changes
Jun 17, 2025
Comment on lines
+111
to
+112
| (:method ((function function) (tensor abstract-tensor &optional (target nil targetp))) | ||
| (map! function (if targetp target (deep-copy-tensor tensor))))) |
Contributor
There was a problem hiding this comment.
This doesn't apply function to tensor when targetp.
This change isn't actually necessary for map because we have map-to above.
Comment on lines
140
to
+145
| (define-backend-implementation scale :lisp | ||
| (lambda (tensor factor) | ||
| (scale! (deep-copy-tensor tensor) factor))) | ||
| (lambda (tensor factor &optional (target nil targetp)) | ||
| (scale! (if targetp | ||
| target | ||
| (deep-copy-tensor tensor)) | ||
| factor))) |
Contributor
There was a problem hiding this comment.
Similar to the issue above, this change doesn't actually scale the elements of tensor into target but rather scales the elements of target itself.
Edit: My recommendation is to add a function scale-to modeled after map-to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended to complete #175
Let me know if this works.
And I can add for more functions, but is there any exhaustive list on mind?