feature: add RedisCluster CRD to supported Service Binding types#1407
feature: add RedisCluster CRD to supported Service Binding types#1407keanucz wants to merge 1 commit intoredhat-developer:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Keanu73. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
=======================================
Coverage 58.21% 58.21%
=======================================
Files 35 35
Lines 3011 3011
=======================================
Hits 1753 1753
Misses 1090 1090
Partials 168 168 Continue to review full report in Codecov by Sentry.
|
|
Thanks for the PR! Could you add an acceptance test for this to |
Changes
This adds the RedisCluster CRD type to the supported Service Binding registry bindings.
/kind enhancement
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.