feat(domains): add custom click tracking support#195
Merged
Conversation
Add tracking_subdomain field to CreateParams, UpdateParams, CreateDomainResponse, and Domain. Add open_tracking and click_tracking to Domain and CreateDomainResponse. Make Record.priority NotRequired to correctly reflect API responses.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
rehanvdm
approved these changes
Apr 9, 2026
Contributor
rehanvdm
left a comment
rehanvdm
left a comment
There was a problem hiding this comment.
Minor changes, looks goo
Co-authored-by: Rehan van der Merwe <rehan.vdm4@gmail.com>
Co-authored-by: Rehan van der Merwe <rehan.vdm4@gmail.com>
Co-authored-by: Rehan van der Merwe <rehan.vdm4@gmail.com>
Co-authored-by: Rehan van der Merwe <rehan.vdm4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tracking_subdomain field to CreateParams, UpdateParams, CreateDomainResponse, and Domain.
Add open_tracking and click_tracking to Domain and CreateDomainResponse.
Make Record.priority NotRequired to correctly reflect API responses.
Summary by cubic
Adds custom open/click tracking for domains with a configurable
tracking_subdomain. Domain responses now include optionalopen_tracking,click_tracking, and a new Tracking CNAME record.New Features
tracking_subdomaintoCreateParamsandUpdateParams.open_tracking,click_tracking, andtracking_subdomaininDomainandCreateDomainResponse.Bug Fixes
Record.priorityoptional to match API responses.Written for commit 76814c0. Summary will update on new commits.